This repository was archived by the owner on Aug 7, 2020. It is now read-only.
fix(oui-modal): allow 2 way binding on some attributes #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxelPeter
suggested changes
May 16, 2018
| title: "@?", | ||
| primaryAction: "&?", | ||
| primaryLabel: "@?", | ||
| primaryLabel: "<?", |
Contributor
There was a problem hiding this comment.
No need to change the binding, it will break the existing oui-modal on managers. Just removing the :: is enough
Jisay
force-pushed
the
fix/modalIn2WayBinding
branch
from
c22ce6b to
124dba7
Compare
AxelPeter
approved these changes
May 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I want to load some informations during modal controller initialization, it can happen that I need to display an error when the action in the modal is not possible.
In this case button could also be different, so I need one time binding to be removed on
type,primaryLabelandsecondaryLabelattributes.