This repository was archived by the owner on Aug 7, 2020. It is now read-only.
chore(oui-calendar): bump version of flatpickr to v4.5.0 #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxelPeter
requested review from
JDownloader,
cbourgois,
neolitec,
rfougier and
whispyy
antleblanc
reviewed
May 28, 2018
| "eslint-loader": "^1.9.0", | ||
| "eventsource-polyfill": "^0.9.6", | ||
| "express": "^4.15.3", | ||
| "flatpickr": "4.4.4", |
There was a problem hiding this comment.
Existing any reason of have flatpickr as a devDependencies? I took popper.js as an example which is as a dependencies instead.
There was a problem hiding this comment.
Yes, it was because of this import: https://github.com/ovh-ux/ovh-ui-angular/blob/master/packages/oui-calendar/src/calendar.controller.js
But it's the same for Popper.js. I'll add it as a dependency.
neolitec
pushed a commit
that referenced
this pull request
Jun 21, 2018
* chore(oui-calendar): bump version of flatpickr to v4.5.0 * chore(oui-calendar): update flatpickr as a dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/flatpickr/flatpickr/releases/tag/v4.5.0
Resolves the logs
Error{}when launching the unit tests