Skip to content
This repository was archived by the owner on Aug 7, 2020. It is now read-only.

chore(oui-calendar): bump version of flatpickr to v4.5.0 #193

Merged
merged 2 commits into from
May 28, 2018
Merged

chore(oui-calendar): bump version of flatpickr to v4.5.0 #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cceccd
chore(oui-calendar): bump version of flatpickr to v4.5.0
May 25, 2018
0862e4e
chore(oui-calendar): update flatpickr as a dependency
May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
},
"dependencies": {
"escape-string-regexp": "^1.0.5",
"popper.js": "^1.12.9"
"popper.js": "^1.12.9",
"flatpickr": "4.5.0"
},
"devDependencies": {
"angular": "~1.6.1",
Expand All @@ -61,7 +62,6 @@
"eslint-loader": "^1.9.0",
"eventsource-polyfill": "^0.9.6",
"express": "^4.15.3",
"flatpickr": "4.4.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing any reason of have flatpickr as a devDependencies? I took popper.js as an example which is as a dependencies instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was because of this import: https://github.com/ovh-ux/ovh-ui-angular/blob/master/packages/oui-calendar/src/calendar.controller.js

But it's the same for Popper.js. I'll add it as a dependency.

"html-loader": "^0.5.1",
"html-webpack-plugin": "^2.26.0",
"istanbul-instrumenter-loader": "^3.0.0",
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3443,9 +3443,9 @@ flat-cache@^1.2.1:
graceful-fs "^4.1.2"
write "^0.2.1"

flatpickr@4.4.4:
version "4.4.4"
resolved "https://registry.yarnpkg.com/flatpickr/-/flatpickr-4.4.4.tgz#fdeb083ca3d580eecb822a4080f67b06f0294fc7"
flatpickr@4.5.0:
version "4.5.0"
resolved "https://registry.yarnpkg.com/flatpickr/-/flatpickr-4.5.0.tgz#f72c7164a1c24e3ad419e3b2209d1a2d3604724a"

flatten@^1.0.2:
version "1.0.2"
Expand Down