Skip to content
This repository was archived by the owner on Aug 7, 2020. It is now read-only.

feat(oui-popover): add ng-template and title attribute support #301

Merged
merged 2 commits into from
Oct 31, 2018
Merged

feat(oui-popover): add ng-template and title attribute support #301

merged 2 commits into from
Oct 31, 2018

Conversation

@AxelPeter
Copy link
Contributor

@AxelPeter AxelPeter commented Oct 25, 2018 •
edited
Loading

UK-55

  • Refactor oui-popover to have the same functioning as oui-tooltip
  • Add deprecated support for the old functionning of oui-popover
  • Add title attribute support
  • Add ng-template support to load the content of a popover
  • Add unit tests

Related to:

@AxelPeter AxelPeter mentioned this pull request Oct 25, 2018
Merged
@AxelPeter AxelPeter changed the title feat(oui-popover): feat(oui-popover): add ng-template and title attribute support Oct 31, 2018
@AxelPeter AxelPeter merged commit 1f790fb into develop Oct 31, 2018
@AxelPeter AxelPeter deleted the refactor/popover branch October 31, 2018 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@euhmeuh euhmeuh Awaiting requested review from euhmeuh

@FredericEspiau FredericEspiau Awaiting requested review from FredericEspiau

@JeremyDec JeremyDec Awaiting requested review from JeremyDec

Assignees

No one assigned

Labels

enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AxelPeter