Skip to content

Conversation

@var-poro
Copy link
Contributor

No description provided.

@var-poro var-poro force-pushed the feat-combobox branch 2 times, most recently from ec107f2 to 47fc40d Compare May 14, 2025 20:53
Copy link
Contributor

@dpellier dpellier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the doc:

  • the font in the input is incorrect
  • the outline square bottom borders stays after selection, should be round again when content is closed
  • combobox root should be inline-block (see clearable example on the doc to see the issue)
  • disabled style is incorrect
  • item disabled example doesn't work
  • exampe "Custom Item" is the static source parameter, we can't see the function used
  • it feels weird to filter only by label when we have customRenderer
  • example "Form Field" should add a label (try with FormFieldLabel and see if it focus the combobox on click, otherwise use a ComboboxLabel)
  • "Controlled" is KO, Dog is not selected in the combobox on initial render
  • Add !dev tag to "Controlled" to remove it from the list of doc page

@var-poro var-poro force-pushed the feat-combobox branch 2 times, most recently from 2f71dc2 to 96c77d3 Compare May 19, 2025 07:34
@var-poro var-poro force-pushed the feat-combobox branch 4 times, most recently from ea0a5ef to 4811e38 Compare May 20, 2025 15:41
@dpellier dpellier force-pushed the feat-combobox branch 3 times, most recently from 059d574 to 2505949 Compare June 6, 2025 09:45
@var-poro var-poro closed this Jun 12, 2025
@dpellier dpellier deleted the feat-combobox branch June 30, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants