Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

feat(metrics): add a basic auth#69

Merged
wilfriedroset merged 2 commits intoovh:masterfrom
aurrelhebert:feat/basic_auth/metrics
Sep 7, 2021
Merged

feat(metrics): add a basic auth#69
wilfriedroset merged 2 commits intoovh:masterfrom
aurrelhebert:feat/basic_auth/metrics

Conversation

@aurrelhebert
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread middlewares/metrics_auth.go Outdated
Comment thread cmd/root.go Outdated
Comment thread middlewares/metrics_auth.go Outdated
@Alkorin
Copy link
Copy Markdown
Member

Alkorin commented Jul 21, 2021

Can't you use https://echo.labstack.com/middleware/basic-auth/ ?

@aurrelhebert
Copy link
Copy Markdown
Contributor Author

Hi thanks all for the review, PR updated to use echo middleware and an Hash password

@aurrelhebert aurrelhebert force-pushed the feat/basic_auth/metrics branch 4 times, most recently from c0b9919 to f5d1d1c Compare July 23, 2021 07:39
@aurrelhebert
Copy link
Copy Markdown
Contributor Author

Up

@wilfriedroset wilfriedroset merged commit 75da510 into ovh:master Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants