Remove hard-coded OS language & useSpla notions#10954
Merged
JacquesLarique merged 3 commits intorelease/components-w10from Feb 29, 2024
Merged
Remove hard-coded OS language & useSpla notions#10954JacquesLarique merged 3 commits intorelease/components-w10from
JacquesLarique merged 3 commits intorelease/components-w10from
Conversation
github-actions
bot
added
universe-bare-metal-cloud
translation required
feature
darsene
previously approved these changes
Feb 20, 2024
JayBeeDe
changed the title
anooparveti
previously approved these changes
Feb 20, 2024
ref: MANAGER-12921 Signed-off-by: Jean-Baptiste Delon <jean-baptiste.delon@ovhcloud.com>
ref: MANAGER-12921 Signed-off-by: Jean-Baptiste Delon <jean-baptiste.delon@ovhcloud.com>
JayBeeDe
force-pushed
the
feat/MANAGER-12921
branch
from
e4d217c to
8deb029
Compare
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
|
anooparveti
approved these changes
Feb 29, 2024
qpavy
approved these changes
Feb 29, 2024
JacquesLarique
changed the base branch from
master
to
release/components-w10
14 tasks
JacquesLarique
pushed a commit
that referenced
this pull request
Mar 4, 2024
ref: MANAGER-12921 Signed-off-by: Jean-Baptiste Delon <jean-baptiste.delon@ovhcloud.com> Co-authoredf-by: CDS Translator Agent <opensource@ovh.net>
kqesar
pushed a commit
that referenced
this pull request
Mar 6, 2024
ref: MANAGER-12921 Signed-off-by: Jean-Baptiste Delon <jean-baptiste.delon@ovhcloud.com> Co-authoredf-by: CDS Translator Agent <opensource@ovh.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterBreaking change is mentioned in relevant commitsDescription
Remove useSpla and language options for dedicated OS installation.
In fact we are not removing those options, they are moved to the OS specific options section that is displaying form dynamically using baremetal API: see internal ticket MANAGER-10557 that has been recently prodded.
Advantages of doing that are:
In order to reduce the cohabitation time with the 2 options, the dynamic options will appear the day of the deployment of this PR to EU/CA regions.
For US region, there will be a few days of cohabitation period with duplicated questions language and useSpla. API can handle that: priority is given to the dynamic (new option).
Related
ref: MANAGER-12921