Skip to content

feat(ovhcloud-cli): add share features#169

Merged
amstuta merged 5 commits intomainfrom
dev/mrocher/share-cli
Apr 2, 2026
Merged

feat(ovhcloud-cli): add share features#169
amstuta merged 5 commits intomainfrom
dev/mrocher/share-cli

Conversation

@Gandalf-Le-Dev
Copy link
Copy Markdown
Contributor

Description

Add support for File Storage As A Service (Share) management commands to the CLI, under ovhcloud cloud storage-file share.

This introduces full CRUD operations for:

  • Shares: list, get, create, edit, delete
  • Share ACLs: list, get, create, delete
  • Share Snapshots: list, get, create, delete

Also updates the schemas Makefile target to accept a UNIVERSE argument, making it reusable for regenerating any API schema (not just cloud).

Type of change

  • New feature (non-breaking change which adds functionality)
  • Improvement (improvement of existing commands)

@Gandalf-Le-Dev Gandalf-Le-Dev requested a review from a team as a code owner April 2, 2026 13:31
@Gandalf-Le-Dev Gandalf-Le-Dev force-pushed the dev/mrocher/share-cli branch from 2fe1a31 to 24a864d Compare April 2, 2026 13:31
Signed-off-by: Mathis Rocher <mathis.rocher@corp.ovh.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds File Storage as a Service (Share) management to the ovhcloud CLI under ovhcloud cloud storage-file share, including share CRUD plus ACL and snapshot subcommands, and updates tooling/docs to support the new feature.

Changes:

  • Add cloud storage-file share command tree (shares, share ACLs, share snapshots) backed by new Cloud service handlers and templates.
  • Regenerate/extend the Cloud OpenAPI schema asset and add parameter نمونه for share creation.
  • Add a reusable make schemas UNIVERSE=<name> target and generated CLI documentation pages.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Makefile Adds schemas target supporting UNIVERSE selection for schema regeneration.
internal/services/cloud/templates/cloud_storage_file_share.tmpl Adds human-friendly output template for share get.
internal/services/cloud/templates/cloud_storage_file_share_snapshot.tmpl Adds human-friendly output template for share snapshot get.
internal/services/cloud/parameter-samples/storage-file-share-create.json Adds example request body for share creation.
internal/services/cloud/cloud_storage_file.go Implements share/ACL/snapshot list/get/create/edit/delete service functions.
internal/cmd/cloud_storage_file.go Wires new Cobra commands/flags for cloud storage-file share ....
internal/cmd/cloud_project.go Registers the new storage-file command under ovhcloud cloud.
internal/assets/api-schemas/cloud.json Updates embedded Cloud OpenAPI schema (includes share/ACL/snapshot endpoints and other regenerated changes).
doc/ovhcloud_cloud.md Adds storage-file to the cloud command index.
doc/ovhcloud_cloud_storage-file.md New generated docs for ovhcloud cloud storage-file.
doc/ovhcloud_cloud_storage-file_share.md New generated docs for ovhcloud cloud storage-file share.
doc/ovhcloud_cloud_storage-file_share_snapshot.md New generated docs for snapshot subcommand group.
doc/ovhcloud_cloud_storage-file_share_snapshot_list.md New generated docs for snapshot list.
doc/ovhcloud_cloud_storage-file_share_snapshot_get.md New generated docs for snapshot get.
doc/ovhcloud_cloud_storage-file_share_snapshot_delete.md New generated docs for snapshot delete.
doc/ovhcloud_cloud_storage-file_share_snapshot_create.md New generated docs for snapshot create.
doc/ovhcloud_cloud_storage-file_share_list.md New generated docs for share list.
doc/ovhcloud_cloud_storage-file_share_get.md New generated docs for share get.
doc/ovhcloud_cloud_storage-file_share_edit.md New generated docs for share edit.
doc/ovhcloud_cloud_storage-file_share_delete.md New generated docs for share delete.
doc/ovhcloud_cloud_storage-file_share_create.md New generated docs for share create.
doc/ovhcloud_cloud_storage-file_share_acl.md New generated docs for ACL subcommand group.
doc/ovhcloud_cloud_storage-file_share_acl_list.md New generated docs for acl list.
doc/ovhcloud_cloud_storage-file_share_acl_get.md New generated docs for acl get.
doc/ovhcloud_cloud_storage-file_share_acl_delete.md New generated docs for acl delete.
doc/ovhcloud_cloud_storage-file_share_acl_create.md New generated docs for acl create.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/services/cloud/parameter-samples/storage-file-share-create.json Outdated
Comment thread Makefile Outdated
Comment thread internal/services/cloud/cloud_storage_file.go Outdated
Gandalf-Le-Dev and others added 4 commits April 2, 2026 16:54
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Gandalf_Le_Dev <46865726+Gandalf-Le-Dev@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Gandalf_Le_Dev <46865726+Gandalf-Le-Dev@users.noreply.github.com>
Signed-off-by: Mathis Rocher <mathis.rocher@corp.ovh.com>
…ud-cli into dev/mrocher/share-cli

Signed-off-by: Mathis Rocher <mathis.rocher@corp.ovh.com>
@Gandalf-Le-Dev Gandalf-Le-Dev force-pushed the dev/mrocher/share-cli branch from d3dff3e to 0cf5418 Compare April 2, 2026 15:13
@amstuta amstuta merged commit e26e7ac into main Apr 2, 2026
7 checks passed
@amstuta amstuta mentioned this pull request Apr 2, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants