Merged
Conversation
2fe1a31 to
24a864d
Compare
Signed-off-by: Mathis Rocher <mathis.rocher@corp.ovh.com>
24a864d to
81165e8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds File Storage as a Service (Share) management to the ovhcloud CLI under ovhcloud cloud storage-file share, including share CRUD plus ACL and snapshot subcommands, and updates tooling/docs to support the new feature.
Changes:
- Add
cloud storage-file sharecommand tree (shares, share ACLs, share snapshots) backed by new Cloud service handlers and templates. - Regenerate/extend the Cloud OpenAPI schema asset and add parameter نمونه for share creation.
- Add a reusable
make schemas UNIVERSE=<name>target and generated CLI documentation pages.
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Adds schemas target supporting UNIVERSE selection for schema regeneration. |
| internal/services/cloud/templates/cloud_storage_file_share.tmpl | Adds human-friendly output template for share get. |
| internal/services/cloud/templates/cloud_storage_file_share_snapshot.tmpl | Adds human-friendly output template for share snapshot get. |
| internal/services/cloud/parameter-samples/storage-file-share-create.json | Adds example request body for share creation. |
| internal/services/cloud/cloud_storage_file.go | Implements share/ACL/snapshot list/get/create/edit/delete service functions. |
| internal/cmd/cloud_storage_file.go | Wires new Cobra commands/flags for cloud storage-file share .... |
| internal/cmd/cloud_project.go | Registers the new storage-file command under ovhcloud cloud. |
| internal/assets/api-schemas/cloud.json | Updates embedded Cloud OpenAPI schema (includes share/ACL/snapshot endpoints and other regenerated changes). |
| doc/ovhcloud_cloud.md | Adds storage-file to the cloud command index. |
| doc/ovhcloud_cloud_storage-file.md | New generated docs for ovhcloud cloud storage-file. |
| doc/ovhcloud_cloud_storage-file_share.md | New generated docs for ovhcloud cloud storage-file share. |
| doc/ovhcloud_cloud_storage-file_share_snapshot.md | New generated docs for snapshot subcommand group. |
| doc/ovhcloud_cloud_storage-file_share_snapshot_list.md | New generated docs for snapshot list. |
| doc/ovhcloud_cloud_storage-file_share_snapshot_get.md | New generated docs for snapshot get. |
| doc/ovhcloud_cloud_storage-file_share_snapshot_delete.md | New generated docs for snapshot delete. |
| doc/ovhcloud_cloud_storage-file_share_snapshot_create.md | New generated docs for snapshot create. |
| doc/ovhcloud_cloud_storage-file_share_list.md | New generated docs for share list. |
| doc/ovhcloud_cloud_storage-file_share_get.md | New generated docs for share get. |
| doc/ovhcloud_cloud_storage-file_share_edit.md | New generated docs for share edit. |
| doc/ovhcloud_cloud_storage-file_share_delete.md | New generated docs for share delete. |
| doc/ovhcloud_cloud_storage-file_share_create.md | New generated docs for share create. |
| doc/ovhcloud_cloud_storage-file_share_acl.md | New generated docs for ACL subcommand group. |
| doc/ovhcloud_cloud_storage-file_share_acl_list.md | New generated docs for acl list. |
| doc/ovhcloud_cloud_storage-file_share_acl_get.md | New generated docs for acl get. |
| doc/ovhcloud_cloud_storage-file_share_acl_delete.md | New generated docs for acl delete. |
| doc/ovhcloud_cloud_storage-file_share_acl_create.md | New generated docs for acl create. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Gandalf_Le_Dev <46865726+Gandalf-Le-Dev@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Gandalf_Le_Dev <46865726+Gandalf-Le-Dev@users.noreply.github.com>
Signed-off-by: Mathis Rocher <mathis.rocher@corp.ovh.com>
…ud-cli into dev/mrocher/share-cli Signed-off-by: Mathis Rocher <mathis.rocher@corp.ovh.com>
d3dff3e to
0cf5418
Compare
amstuta
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for File Storage As A Service (Share) management commands to the CLI, under
ovhcloud cloud storage-file share.This introduces full CRUD operations for:
Also updates the
schemasMakefile target to accept aUNIVERSEargument, making it reusable for regenerating any API schema (not justcloud).Type of change