Skip to content

[PWCI] "[v4] event/cnxk: fix offload flags" #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
+569 −300
Open

[PWCI] "[v4] event/cnxk: fix offload flags" #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
0e42784
doc: add limitations of synchronous flow API with HWS
MaayanKashani1 Nov 5, 2025
fe433b5
doc: update recommended versions for ice and i40e
hailinxx Nov 24, 2025
a223460
net/mlx5: fix flex flow item header length
viacheslavo Nov 18, 2025
cc12189
net/mlx5: revert update of flow engine configuration
raslandarawsheh Nov 24, 2025
cd6519d
doc: update flow count requirements in mlx5 guide
sodar Nov 24, 2025
79375d1
examples/l3fwd: add Tx burst size configuration option
sivapt12 Nov 6, 2025
2001c8e
examples/l3fwd: force link speed
huangdengdui1 Aug 27, 2025
a61cd1c
examples/l3fwd-power: force link speed
huangdengdui1 Aug 27, 2025
c97d223
examples/server_node_efd: fix format overflow
shemminger Nov 20, 2025
6605265
examples/vdpa: fix format overflow
shemminger Nov 20, 2025
eb2c85d
examples/ip_reassembly: add check before formatting name
shemminger Nov 20, 2025
03a8f97
examples: enable format truncation warning
shemminger Nov 20, 2025
9cd1dcc
drivers/net: fix Tx packet prepare
tmonjalo Nov 19, 2025
899e7bb
doc: add Pollara 400 device in ionic guide
andrewb24 Nov 20, 2025
020d6f8
doc: update AMD EPYC guide
vipinamd Sep 22, 2025
7b2b79d
doc: update build instructions in Windows guide
Nov 12, 2025
da1cd5c
doc: fix note in FreeBSD guide
tmonjalo Oct 31, 2025
75204e8
doc: update Python version in FreeBSD guide
shemminger Nov 3, 2025
9fcc10e
doc: remove KNI diagrams
shemminger Aug 14, 2025
83e611c
doc: build separately with Meson install tag
bluca Dec 23, 2024
0f51c2a
doc: add tested platforms with NVIDIA NICs for 25.11
raslandarawsheh Nov 20, 2025
1142310
doc: add tested Intel platforms with Intel NICs for 25.11
yujian4x Nov 24, 2025
2815d50
version: 25.11-rc4
tmonjalo Nov 25, 2025
ffbd99c
event/cnxk: fix offload flags
PavanNikhilesh Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
25.11.0-rc3
25.11.0-rc4
3 changes: 3 additions & 0 deletions doc/api/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ example = custom_target('examples.dox',
depfile: 'examples.dox.d',
install: get_option('enable_docs'),
install_dir: htmldir,
install_tag: 'doc',
build_by_default: get_option('enable_docs'))

# set up common Doxygen configuration
Expand Down Expand Up @@ -76,6 +77,7 @@ doxy_html_build = custom_target('doxygen-html',
command: [generate_doxygen, '@OUTPUT@', doxygen, '@INPUT@'],
install: get_option('enable_docs'),
install_dir: htmldir,
install_tag: 'doc',
build_by_default: get_option('enable_docs'))

doc_targets += doxy_html_build
Expand All @@ -90,6 +92,7 @@ doxy_man_build = custom_target('doxygen-man',
command: [generate_doxygen, '@OUTPUT@', doxygen, '@INPUT@'],
install: get_option('enable_docs'),
install_dir: get_option('datadir'),
install_tag: 'doc',
build_by_default: get_option('enable_docs'))

doc_targets += doxy_man_build
Expand Down
4 changes: 3 additions & 1 deletion doc/guides/cryptodevs/ionic.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.. SPDX-License-Identifier: BSD-3-Clause
Copyright 2021-2024 Advanced Micro Devices, Inc.
Copyright 2021-2025 Advanced Micro Devices, Inc.
IONIC Crypto Driver
===================
Expand All @@ -16,6 +16,8 @@ It currently supports the below models:
`(pdf) <https://www.amd.com/content/dam/amd/en/documents/pensando-technical-docs/product-briefs/pensando-elba-product-brief.pdf>`__
- DSC3-400 dual-port 400G Distributed Services Card
`(pdf) <https://www.amd.com/content/dam/amd/en/documents/pensando-technical-docs/product-briefs/pensando-dsc3-product-brief.pdf>`__
- Pollara 400 single-port 400G AI NIC
`(pdf) <https://www.amd.com/content/dam/amd/en/documents/pensando-technical-docs/product-briefs/pollara-product-brief.pdf>`__

Please visit the
`AMD Pensando Networking
Expand Down
10 changes: 5 additions & 5 deletions doc/guides/freebsd_gsg/build_dpdk.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ The following FreeBSD packages are required to build DPDK:
* meson
* ninja
* pkgconf
* py38-pyelftools
* py311-pyelftools

.. note:
.. note::

The specific package for pyelftools is dependent on the version of python in use,
Python 3.8 being the version at type of writing, hence the ``py38`` prefix.
The specific package for pyelftools is dependent on the version of python in use,
Python 3.11 being the version at type of writing, hence the ``py311`` prefix.
Comment on lines +21 to +24
Copy link

@coderabbitai coderabbitai bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in documentation note.

Line 24 contains a grammatical error: "at type of writing" should be "at time of writing".

Apply this diff to fix the typo:

    The specific package for pyelftools is dependent on the version of python in use,
-   Python 3.11 being the version at type of writing, hence the ``py311`` prefix.
+   Python 3.11 being the version at time of writing, hence the ``py311`` prefix.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.. note::
The specific package for pyelftools is dependent on the version of python in use,
Python 3.8 being the version at type of writing, hence the ``py38`` prefix.
The specific package for pyelftools is dependent on the version of python in use,
Python 3.11 being the version at type of writing, hence the ``py311`` prefix.
.. note::
The specific package for pyelftools is dependent on the version of python in use,
Python 3.11 being the version at time of writing, hence the ``py311`` prefix.
🤖 Prompt for AI Agents 
In doc/guides/freebsd_gsg/build_dpdk.rst around lines 21 to 24, the
documentation note contains a typo: replace the phrase "at type of writing" with
"at time of writing" so the sentence reads that Python 3.11 was the version at
time of writing; update the text accordingly.


These can be installed using (as root)::

pkg install meson pkgconf py38-pyelftools
pkg install meson pkgconf py311-pyelftools

To compile the required kernel modules for memory management and working
with physical NIC devices, the kernel sources for FreeBSD also
Expand Down
41 changes: 38 additions & 3 deletions doc/guides/linux_gsg/amd_platform.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ Tuning Guides for AMD EPYC SoC

#. `GENOA <https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/tuning-guides/58017-amd-epyc-9004-tg-data-plane-dpdk.pdf>`_

#. `BERGAMO|SIENNA <https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/tuning-guides/58310_amd-epyc-8004-tg-data-plane-dpdk.pdf>`_
#. `BERGAMO|SIENA <https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/tuning-guides/58310_amd-epyc-8004-tg-data-plane-dpdk.pdf>`_

#. `TURIN <https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/tuning-guides/58468_amd-epyc-9005-tg-data-plane-dpdk.pdf>`_


General Requirements
Expand Down Expand Up @@ -86,10 +88,43 @@ Core
~~~~

AMD EPYC SoC supports CPU power functions via ``rte_power`` API from `23.11 LTS` onwards.
These are tested and validated on MILAN, GENOA, BERGAMO and SIENA
using Linux kernel `6.4` and above with ``amd_pstate`` power driver.
These are tested and validated on MILAN, GENOA, BERGAMO, SIENA and TURIN
using Linux kernel `6.4` and above with ``amd_pstate`` power driver in ``passive`` mode.

.. note::

* Power libraries are supported on Linux only.
* DPDK uncore support on Linux is work in progress.

Uncore
~~~~~~

AMD EPYC SoC support UNCORE power functions via ``rte_power_uncore`` from `25.03` onwards.
These are tested and validated on GENOA, SIENA and TURIN.
Please refer the tuning guides to enable ``HSMP`` and DPDK power management guide.


NIC
---

To use Solarflare x4 on AMD EPYC TURIN, please ensure the following

#. Upgrade Linux or distro version to 6.13 or higher.

#. Disable PCIe power option via ``vfio-pci.disable_idle_d3=1`` in GRUB.

#. Enable the hardware with out-of-tree sfc (contact Solarflare) Linux kernel driver first;
then bind with ``vfio-pci`` next.

#. Please use PMD args ``fw_variant=ultra-low-latency,perf_profile=throughput``.

To use Solarflare x2 on AMD EPYC TURIN, please ensure the following

#. Upgrade Linux or distro version to 6.13 or higher.

#. Disable PCIe power option via ``vfio-pci.disable_idle_d3=1`` in GRUB.

#. Enable the hardware with ``sfc`` Linux Kernel Driver first;
then bind with ``vfio-pci`` next.

#. Please use PMD args ``fw_variant=ultra-low-latency,perf_profile=throughput``.
1 change: 1 addition & 0 deletions doc/guides/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ html_guides = custom_target('html_guides',
depfile: '.html.d',
build_by_default: get_option('enable_docs'),
install: get_option('enable_docs'),
install_tag: 'doc',
Copy link

@coderabbitai coderabbitai bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

Script executed:

#!/bin/bash
# Check minimum required Meson version in the project
echo "=== Searching for Meson version requirements ==="
rg -n "meson_version|project\(" --type python meson.build | head -30

Repository: ovsrobot/dpdk

<shell_result>
Repository: ovsrobot/dpdk
Script execution failed with error: Request timed out after 120000ms (requestId=e5d6d7a5-90f0-42c0-9fe9-9d1be4198559)
</shell_result>

Script executed:

#!/bin/bash
# Check the root meson.build for version requirements
echo "=== Checking root meson.build ==="
head -50 meson.build 2>/dev/null || echo "Root meson.build not found"

# Also check if there's version info in the doc/guides directory
echo ""
echo "=== Checking doc/guides/meson.build ==="
head -30 doc/guides/meson.build 2>/dev/null || echo "File not found"

Repository: ovsrobot/dpdk

<shell_result>
Repository: ovsrobot/dpdk
Exit code: 0

stdout:

=== Checking root meson.build ===
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017-2019 Intel Corporation

project('DPDK', 'c',
        version: files('VERSION'),
        license: 'BSD',
        default_options: [
            'buildtype=release',
            'c_std=c11',
            'default_library=static',
            'warning_level=2',
        ],
        meson_version: '>= 0.57.2'
        # meson_version_windows: '>= 1.5.2'
)

fs = import('fs')

# check for developer mode
developer_mode = false
if get_option('developer_mode').auto()
    developer_mode = fs.exists('.git')
else
    developer_mode = get_option('developer_mode').enabled()
endif
if developer_mode
    message('## Building in Developer Mode ##')
endif

# set up some global vars for compiler, platform, configuration, etc.
cc = meson.get_compiler('c')
dpdk_source_root = meson.current_source_dir()
dpdk_build_root = meson.current_build_dir()
dpdk_conf = configuration_data()
dpdk_includes = []
dpdk_libraries = []
dpdk_static_libraries = []
dpdk_shared_lib_deps = []
dpdk_static_lib_deps = []
dpdk_arch_headers = []
dpdk_arch_indirect_headers = []
dpdk_generic_headers = []
dpdk_headers = []
dpdk_indirect_headers = []
dpdk_drivers_headers = []
dpdk_driver_classes = []
dpdk_drivers = []
dpdk_extra_ldflags = []
dpdk_libs_deprecated = []
dpdk_apps_disabled = []

=== Checking doc/guides/meson.build ===
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Intel Corporation

sphinx = find_program('sphinx-build', required: get_option('enable_docs'))

if not sphinx.found()
    subdir_done()
endif

extra_sphinx_args = ['-a']
if get_option('werror')
    extra_sphinx_args += '-W'
endif

htmldir = join_paths(get_option('datadir'), 'doc', 'dpdk', 'guides')
html_guides = custom_target('html_guides',
        input: files('index.rst'),
        output: 'html',
        command: [sphinx_wrapper, sphinx, meson.project_version(),
            meson.current_source_dir(), meson.current_build_dir(),
            extra_sphinx_args],
        depfile: '.html.d',
        build_by_default: get_option('enable_docs'),
        install: get_option('enable_docs'),
        install_tag: 'doc',
        install_dir: htmldir)

doc_targets += html_guides
doc_target_names += 'HTML_Guides'

</shell_result>

Based on my verification, I've found a compatibility issue with the added install_tag parameter.

The project's root meson.build specifies meson_version: '>= 0.57.2', but the install_tag parameter requires Meson 0.60.0 or later. The minimum version requirement (0.57.2) does not meet the feature requirement (0.60.0).

Update minimum Meson version requirement to support install_tag parameter.

The addition of install_tag: 'doc' requires Meson version 0.60.0 or later. The project's current minimum version is 0.57.2. Either update the minimum Meson version in meson.build to >= 0.60.0, or remove the install_tag parameter from the custom_target.

🤖 Prompt for AI Agents 
In doc/guides/meson.build around line 25, the custom_target uses install_tag
which requires Meson >= 0.60.0 while the project declares meson_version: '>=
0.57.2'; update the meson_version in the root meson.build to '>= 0.60.0' to
match the new feature, or alternatively remove the install_tag: 'doc' parameter
from this custom_target so it remains compatible with the existing minimum
version.

install_dir: htmldir)

doc_targets += html_guides
Expand Down
72 changes: 4 additions & 68 deletions doc/guides/nics/i40e.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ For X710/XL710/XXV710,
+--------------+-----------------------+------------------+
| DPDK version | Kernel driver version | Firmware version |
+==============+=======================+==================+
| 25.11 | 2.28.13 | 9.55 |
+--------------+-----------------------+------------------+
| 25.07 | 2.28.7 | 9.54 |
+--------------+-----------------------+------------------+
| 25.03 | 2.27.8 | 9.53 |
Expand All @@ -128,57 +130,15 @@ For X710/XL710/XXV710,
+--------------+-----------------------+------------------+
| 21.11 | 2.17.4 | 8.30 |
+--------------+-----------------------+------------------+
| 21.08 | 2.15.9 | 8.30 |
+--------------+-----------------------+------------------+
| 21.05 | 2.15.9 | 8.30 |
+--------------+-----------------------+------------------+
| 21.02 | 2.14.13 | 8.00 |
+--------------+-----------------------+------------------+
| 20.11 | 2.14.13 | 8.00 |
+--------------+-----------------------+------------------+
| 20.08 | 2.12.6 | 7.30 |
+--------------+-----------------------+------------------+
| 20.05 | 2.11.27 | 7.30 |
+--------------+-----------------------+------------------+
| 20.02 | 2.10.19 | 7.20 |
+--------------+-----------------------+------------------+
| 19.11 | 2.9.21 | 7.00 |
+--------------+-----------------------+------------------+
| 19.08 | 2.8.43 | 7.00 |
+--------------+-----------------------+------------------+
| 19.05 | 2.7.29 | 6.80 |
+--------------+-----------------------+------------------+
| 19.02 | 2.7.26 | 6.80 |
+--------------+-----------------------+------------------+
| 18.11 | 2.4.6 | 6.01 |
+--------------+-----------------------+------------------+
| 18.08 | 2.4.6 | 6.01 |
+--------------+-----------------------+------------------+
| 18.05 | 2.4.6 | 6.01 |
+--------------+-----------------------+------------------+
| 18.02 | 2.4.3 | 6.01 |
+--------------+-----------------------+------------------+
| 17.11 | 2.1.26 | 6.01 |
+--------------+-----------------------+------------------+
| 17.08 | 2.0.19 | 6.01 |
+--------------+-----------------------+------------------+
| 17.05 | 1.5.23 | 5.05 |
+--------------+-----------------------+------------------+
| 17.02 | 1.5.23 | 5.05 |
+--------------+-----------------------+------------------+
| 16.11 | 1.5.23 | 5.05 |
+--------------+-----------------------+------------------+
| 16.07 | 1.4.25 | 5.04 |
+--------------+-----------------------+------------------+
| 16.04 | 1.4.25 | 5.02 |
+--------------+-----------------------+------------------+


For X722,

+--------------+-----------------------+------------------+
| DPDK version | Kernel driver version | Firmware version |
+==============+=======================+==================+
| 25.11 | 2.28.13 | 6.51 |
+--------------+-----------------------+------------------+
| 25.07 | 2.28.7 | 6.50 |
+--------------+-----------------------+------------------+
| 25.03 | 2.27.8 | 6.50 |
Expand All @@ -203,30 +163,6 @@ For X722,
+--------------+-----------------------+------------------+
| 21.11 | 2.17.4 | 5.30 |
+--------------+-----------------------+------------------+
| 21.08 | 2.15.9 | 5.30 |
+--------------+-----------------------+------------------+
| 21.05 | 2.15.9 | 5.30 |
+--------------+-----------------------+------------------+
| 21.02 | 2.14.13 | 5.00 |
+--------------+-----------------------+------------------+
| 20.11 | 2.13.10 | 5.00 |
+--------------+-----------------------+------------------+
| 20.08 | 2.12.6 | 4.11 |
+--------------+-----------------------+------------------+
| 20.05 | 2.11.27 | 4.11 |
+--------------+-----------------------+------------------+
| 20.02 | 2.10.19 | 4.11 |
+--------------+-----------------------+------------------+
| 19.11 | 2.9.21 | 4.10 |
+--------------+-----------------------+------------------+
| 19.08 | 2.9.21 | 4.10 |
+--------------+-----------------------+------------------+
| 19.05 | 2.7.29 | 3.33 |
+--------------+-----------------------+------------------+
| 19.02 | 2.7.26 | 3.33 |
+--------------+-----------------------+------------------+
| 18.11 | 2.4.6 | 3.33 |
+--------------+-----------------------+------------------+


Configuration
Expand Down
13 changes: 4 additions & 9 deletions doc/guides/nics/ice.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,6 @@ For E810,
+-----------+---------------+-----------------+-----------+--------------+-----------+
| DPDK | Kernel Driver | OS Default DDP | COMMS DDP | Wireless DDP | Firmware |
+===========+===============+=================+===========+==============+===========+
| 20.11 | 1.3.2 | 1.3.20 | 1.3.24 | N/A | 2.3 |
+-----------+---------------+-----------------+-----------+--------------+-----------+
| 21.02 | 1.4.11 | 1.3.24 | 1.3.28 | 1.3.4 | 2.4 |
+-----------+---------------+-----------------+-----------+--------------+-----------+
| 21.05 | 1.6.5 | 1.3.26 | 1.3.30 | 1.3.6 | 3.0 |
+-----------+---------------+-----------------+-----------+--------------+-----------+
| 21.08 | 1.7.16 | 1.3.27 | 1.3.31 | 1.3.7 | 3.1 |
+-----------+---------------+-----------------+-----------+--------------+-----------+
| 21.11 | 1.7.16 | 1.3.27 | 1.3.31 | 1.3.7 | 3.1 |
+-----------+---------------+-----------------+-----------+--------------+-----------+
| 22.03 | 1.8.3 | 1.3.28 | 1.3.35 | 1.3.8 | 3.2 |
Expand All @@ -95,6 +87,8 @@ For E810,
+-----------+---------------+-----------------+-----------+--------------+-----------+
| 25.07 | 2.2.8 | 1.3.43 | 1.3.55 | 1.3.23 | 4.8 |
+-----------+---------------+-----------------+-----------+--------------+-----------+
| 25.11 | 2.3.14 | 1.3.43 | 1.3.55 | 1.3.25 | 4.9 |
+-----------+---------------+-----------------+-----------+--------------+-----------+

For E830,

Expand All @@ -103,7 +97,8 @@ For E830,
+===========+===============+=================+===========+==============+===========+
| 25.07 | 2.2.8 | 1.3.43 | 1.3.55 | 1.3.23 | 1.0 |
+-----------+---------------+-----------------+-----------+--------------+-----------+

| 25.11 | 2.3.14 | 1.3.43 | 1.3.55 | 1.3.25 | 1.2 |
+-----------+---------------+-----------------+-----------+--------------+-----------+

Dynamic Device Personalization (DDP) package loading
----------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion doc/guides/nics/ionic.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.. SPDX-License-Identifier: BSD-3-Clause
Copyright 2018-2022 Advanced Micro Devices, Inc.
Copyright 2018-2025 Advanced Micro Devices, Inc.

IONIC Driver
============
Expand All @@ -15,6 +15,8 @@ It currently supports the below models:
`(pdf) <https://www.amd.com/content/dam/amd/en/documents/pensando-technical-docs/product-briefs/pensando-elba-product-brief.pdf>`__
- DSC3-400 dual-port 400G Distributed Services Card
`(pdf) <https://www.amd.com/content/dam/amd/en/documents/pensando-technical-docs/product-briefs/pensando-dsc3-product-brief.pdf>`__
- Pollara 400 single-port 400G AI NIC
`(pdf) <https://www.amd.com/content/dam/amd/en/documents/pensando-technical-docs/product-briefs/pollara-product-brief.pdf>`__

Please visit the
`AMD Pensando Networking
Expand Down
Loading