-
Notifications
You must be signed in to change notification settings - Fork 4
[PWCI] "Fixes for Fedora Rawhide" #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ovsrobot
wants to merge
40
commits into
main
Choose a base branch
from
series_36807
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
0e42784
doc: add limitations of synchronous flow API with HWS
MaayanKashani1 fe433b5
doc: update recommended versions for ice and i40e
hailinxx a223460
net/mlx5: fix flex flow item header length
viacheslavo cc12189
net/mlx5: revert update of flow engine configuration
raslandarawsheh cd6519d
doc: update flow count requirements in mlx5 guide
sodar 79375d1
examples/l3fwd: add Tx burst size configuration option
sivapt12 2001c8e
examples/l3fwd: force link speed
huangdengdui1 a61cd1c
examples/l3fwd-power: force link speed
huangdengdui1 c97d223
examples/server_node_efd: fix format overflow
shemminger 6605265
examples/vdpa: fix format overflow
shemminger eb2c85d
examples/ip_reassembly: add check before formatting name
shemminger 03a8f97
examples: enable format truncation warning
shemminger 9cd1dcc
drivers/net: fix Tx packet prepare
tmonjalo 899e7bb
doc: add Pollara 400 device in ionic guide
andrewb24 020d6f8
doc: update AMD EPYC guide
vipinamd 7b2b79d
doc: update build instructions in Windows guide
da1cd5c
doc: fix note in FreeBSD guide
tmonjalo 75204e8
doc: update Python version in FreeBSD guide
shemminger 9fcc10e
doc: remove KNI diagrams
shemminger 83e611c
doc: build separately with Meson install tag
bluca 0f51c2a
doc: add tested platforms with NVIDIA NICs for 25.11
raslandarawsheh 1142310
doc: add tested Intel platforms with Intel NICs for 25.11
yujian4x 2815d50
version: 25.11-rc4
tmonjalo cde0d52
net/nbl: add dummy VLAN offload configuration
Dimon-Zhao fb50c47
net/nbl: fix Rx/Tx stats concurrency
Dimon-Zhao 174db9f
doc: update release notes for 25.11
john-mcnamara-intel bbee934
app/testpmd: fix inner UDP checksum offload
fengchengwen c94a9de
test/debug: fix IOVA mode on PPC64 without huge pages
bluca f4ef899
bus/fslmc: fix const pointer in device name parsing
shemminger 3e48adc
event/cnxk: fix Rx offload flags
PavanNikhilesh 82d9cc9
net/txgbe: fix mailbox interface calls
07f93e7
net/iavf: revert check for PF Rx timestamp support
bruce-richardson d4695b3
maintainers: update for BPF test coverage
tmonjalo f4724ca
bus/ifpga: fix const pointer in device name parsing
david-marchand 714734e
bus/uacce: fix const pointer in device matching
david-marchand 0031dd6
drivers: fix some const pointers in qat drivers
david-marchand 56b446d
crypto/caam_jr: fix const pointer in UIO filename parsing
david-marchand 584e6b2
net/enetfec: fix const pointer in UIO filename parsing
david-marchand 38b9664
net/memif: fix const pointer in socket check
david-marchand b17da19
app/procinfo: fix const pointer in collectd format
david-marchand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 25.11.0-rc3 | ||
| 25.11.0-rc4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,9 @@ Tuning Guides for AMD EPYC SoC | |
|
|
||
| #. `GENOA <https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/tuning-guides/58017-amd-epyc-9004-tg-data-plane-dpdk.pdf>`_ | ||
|
|
||
| #. `BERGAMO|SIENNA <https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/tuning-guides/58310_amd-epyc-8004-tg-data-plane-dpdk.pdf>`_ | ||
| #. `BERGAMO|SIENA <https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/tuning-guides/58310_amd-epyc-8004-tg-data-plane-dpdk.pdf>`_ | ||
|
|
||
| #. `TURIN <https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/tuning-guides/58468_amd-epyc-9005-tg-data-plane-dpdk.pdf>`_ | ||
|
|
||
|
|
||
| General Requirements | ||
|
|
@@ -86,10 +88,43 @@ Core | |
| ~~~~ | ||
|
|
||
| AMD EPYC SoC supports CPU power functions via ``rte_power`` API from `23.11 LTS` onwards. | ||
| These are tested and validated on MILAN, GENOA, BERGAMO and SIENA | ||
| using Linux kernel `6.4` and above with ``amd_pstate`` power driver. | ||
| These are tested and validated on MILAN, GENOA, BERGAMO, SIENA and TURIN | ||
| using Linux kernel `6.4` and above with ``amd_pstate`` power driver in ``passive`` mode. | ||
|
|
||
| .. note:: | ||
|
|
||
| * Power libraries are supported on Linux only. | ||
| * DPDK uncore support on Linux is work in progress. | ||
|
|
||
| Uncore | ||
| ~~~~~~ | ||
|
|
||
| AMD EPYC SoC support UNCORE power functions via ``rte_power_uncore`` from `25.03` onwards. | ||
| These are tested and validated on GENOA, SIENA and TURIN. | ||
| Please refer the tuning guides to enable ``HSMP`` and DPDK power management guide. | ||
|
|
||
|
Comment on lines
+99
to
+105
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix grammar in UNCORE section reference. Line 104 has a grammar issue: "Please refer the tuning guides" should be "Please refer to the tuning guides". Apply this diff to fix the grammar: -Please refer the tuning guides to enable ``HSMP`` and DPDK power management guide.
+Please refer to the tuning guides to enable ``HSMP`` and refer to the DPDK power management guide.🤖 Prompt for AI Agents |
||
|
|
||
| NIC | ||
| --- | ||
|
|
||
| To use Solarflare x4 on AMD EPYC TURIN, please ensure the following | ||
|
|
||
| #. Upgrade Linux or distro version to 6.13 or higher. | ||
|
|
||
| #. Disable PCIe power option via ``vfio-pci.disable_idle_d3=1`` in GRUB. | ||
|
|
||
| #. Enable the hardware with out-of-tree sfc (contact Solarflare) Linux kernel driver first; | ||
| then bind with ``vfio-pci`` next. | ||
|
|
||
| #. Please use PMD args ``fw_variant=ultra-low-latency,perf_profile=throughput``. | ||
|
|
||
| To use Solarflare x2 on AMD EPYC TURIN, please ensure the following | ||
|
|
||
| #. Upgrade Linux or distro version to 6.13 or higher. | ||
|
|
||
| #. Disable PCIe power option via ``vfio-pci.disable_idle_d3=1`` in GRUB. | ||
|
|
||
| #. Enable the hardware with ``sfc`` Linux Kernel Driver first; | ||
| then bind with ``vfio-pci`` next. | ||
|
|
||
| #. Please use PMD args ``fw_variant=ultra-low-latency,perf_profile=throughput``. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: ovsrobot/dpdk
Length of output: 2286
🏁 Script executed:
Repository: ovsrobot/dpdk
Length of output: 4462
🏁 Script executed:
Repository: ovsrobot/dpdk
Length of output: 1993
Based on my verification, the review comment is correct and valid. I've confirmed:
The
*_EXT_UNKNOWNptypes are real DPDK constants defined inlib/mbuf/rte_mbuf_ptype.h(lines 571, 592) and actively used by multiple hardware drivers (axgbe, zxdh, txgbe).The inconsistency is confirmed:
get_ethertype_by_ptype()explicitly handlesRTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWNandRTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN(lines 480, 487), correctly mapping them to IPv4/IPv6 ethertypes. However,parse_l4_proto()has no cases for these ptypes whenin_tunnel=true, causingalign_ptypeto be set to 0, which skips both IPv4 and IPv6 checks and returns 0.The impact is real: This affects L4 protocol detection for tunneled packets with these ptypes, breaking checksum offload and TSO handling as the reviewer stated.
The review comment's analysis and suggested fix are sound. The comment should be kept with classification since this is a genuine bug affecting actual hardware-generated packet types.
Handle
*_EXT_UNKNOWNinner ptypes inparse_l4_protoThe tunnel-aware refactor generally makes sense, but the
in_tunnelmapping currently ignores some inner L3 ptypes that this file otherwise treats as valid IPv4/IPv6:get_ethertype_by_ptype()has explicit cases forRTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWNandRTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN(lines 480, 487), mapping them to IPv4/IPv6 ethertypes.parse_l4_proto(), whenin_tunnelis true,mask_ptype = ptype & RTE_PTYPE_INNER_L3_MASK;is only checked againstINNER_L3_IPV4,INNER_L3_IPV4_EXT,INNER_L3_IPV6, andINNER_L3_IPV6_EXT. For*_EXT_UNKNOWNvalues,align_ptypebecomes 0, so both IPv4 and IPv6 branches are skipped and the function returns 0.Effect: Tunneled packets whose inner header is tagged as
*_EXT_UNKNOWN(generated by hardware drivers like axgbe and zxdh) will no longer have their L4 protocol detected, so they won't go through the UDP/TCP/SCTP checksum and TSO logic even though they were previously recognized as IPv4/IPv6.Consider extending the mapping, for example:
(or any equivalent mapping consistent with how you want to treat "EXT_UNKNOWN").
This keeps inner handling aligned with the rest of the file and avoids unexpectedly disabling checksum handling for a subset of tunneled flows.
Also applies to: 563-571
🤖 Prompt for AI Agents