[PWCI] "app/testpmd: fix incorrect function names in logs" #508

ovsrobot · 2025-12-01T12:43:50Z

NOTE: This is an auto submission for "app/testpmd: fix incorrect function names in logs".

See "http://patchwork.dpdk.org/project/dpdk/list/?series=36816" for details.

Summary by CodeRabbit

Releases
- Version 25.11.0 released (RC designation removed)
Documentation
- Updated network driver documentation with clarified device compatibility information and core requirements
Bug Fixes
- Enhanced error messages with improved context information
Chores
- Code formatting and whitespace cleanup across drivers

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Starting with NVIDIA ConnectX-9, the future devices will support only hardware steering (HWS) flow engine. The software steering options (legacy Verbs and Direct Verbs) have lower performances, and won't be available for new devices. Both flow APIs (sync and async template) will still be supported with the hardware steering flow engine. Fixes: 1b55eeb ("common/mlx5: add ConnectX-9 SuperNIC") Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

The tool ripgrep allows to find files not ending with a line break: rg -Ul '[^\n]\z' The files with a trailing blank lines are shown with this command: rg -Ul '\n\n\z' Files are fixed to end with a single line break. Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

VLAN extend and tpid setting functions have wrong function names mentioned in the error logs causing confusion as functions are not found in code using those names. Replaced static names with dynamic "__func__" predefined identifier. Fixes: 61a3b0e ("app/testpmd: send failure logs to stderr") Cc: stable@dpdk.org Signed-off-by: Anurag Mandal <anurag.mandal@intel.com> Signed-off-by: 0-day Robot <robot@bytheb.org>

sourcery-ai

Sorry @ovsrobot, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

coderabbitai · 2025-12-01T12:44:55Z

Walkthrough

Version string updated from 25.11.0-rc4 to 25.11.0 for final release. Multiple trailing blank line removals and minor formatting corrections across documentation, test vectors, driver files, and other sources. Documentation updates for device compatibility statements in MLX5 and removal of obsolete sections in CXGBE and IPN3KE guides.

Changes

Cohort / File(s)	Summary
Version Update `VERSION`	Version bumped from 25.11.0-rc4 to 25.11.0, removing RC suffix for final release.
Test Vectors `app/test-bbdev/test_vectors/bbdev_null.data`, `turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_high_snr.data`, `turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_low_snr.data`, `turbo_dec_c1_k6144_r0_e34560_sbd_posllr.data`, `turbo_dec_c2_k3136_r0_e4920_sbd_negllr_crc24b.data`, `turbo_enc_c1_k6144_r0_e18448_crc24a.data`, `turbo_enc_c3_k4800_r2_e14412_crc24b.data`	Trailing newline and formatting adjustments; no functional changes to test data.
Documentation Updates `doc/guides/nics/cxgbe.rst`, `doc/guides/nics/ipn3ke.rst`, `doc/guides/nics/mlx5.rst`	CXGBE: removed dash separator. IPN3KE: removed "Limitations or Known issues" subsection. MLX5: enhanced device compatibility notes for dv_flow_en, DV flow steering, and Hardware Steering modes.
PMD Configuration `app/test-pmd/config.c`	Updated error-display calls to include function names via `__func__` for improved context in failure messages.
Driver Formatting (Trailing Blank Lines) `drivers/event/dlb2/dlb2_iface.c`, `drivers/net/bnxt/tf_core/tf_em_common.c`, `drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_act.c`, `drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_class.c`, `drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_defs.h`, `drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_tbl.c`, `drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_wh_plus_class.c`, `drivers/net/gve/base/gve_adminq.c`, `drivers/net/gve/gve_rss.c`, `drivers/net/gve/gve_rss.h`, `drivers/net/hinic/base/hinic_pmd_mbox.c`, `drivers/net/hinic/base/hinic_pmd_niccfg.c`, `drivers/net/intel/e1000/base/e1000_82575.c`, `drivers/net/intel/e1000/base/e1000_mbx.c`, `drivers/net/intel/e1000/base/e1000_vf.c`, `drivers/net/intel/ice/base/ice_flex_pipe.c`, `drivers/net/intel/ice/base/ice_hw_autogen.h`, `drivers/net/intel/ixgbe/base/ixgbe_dcb_82599.c`, `drivers/net/intel/ixgbe/base/ixgbe_x540.h`, `drivers/net/mlx5/hws/mlx5dr_buddy.c`, `drivers/net/nfp/nfp_ipsec.c`, `drivers/net/nfp/nfpcore/nfp_elf.c`, `drivers/net/ngbe/base/ngbe_dummy.h`, `drivers/net/octeontx/base/octeontx_bgx.h`, `drivers/net/txgbe/base/txgbe_dcb.c`, `drivers/net/txgbe/base/txgbe_dcb_hw.c`, `drivers/net/txgbe/base/txgbe_dummy.h`, `drivers/net/txgbe/base/txgbe_eeprom.c`, `drivers/net/virtio/virtio_cvq.c`, `drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_selftest.c`, `drivers/vdpa/mlx5/mlx5_vdpa_event.c`	Removed trailing blank lines after functions; whitespace-only formatting adjustments.
Driver Syntax Fixes `drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor2_class.c`, `drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor_class.c`	Removed trailing commas from array initializers for syntactic consistency.
Driver i40e `drivers/net/intel/i40e/base/i40e_adminq.c`, `drivers/net/ngbe/base/ngbe_phy.c`	Removed trailing blank lines after functions.
Build Configuration `drivers/net/hinic/base/meson.build`	Removed `deps += ['hash']` dependency addition.
Config and License `dts/configurations/tests_config.example.yaml`, `license/Linux-syscall-note`	Commented configuration option and trailing blank line cleanup in license file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This pull request is predominantly homogeneous whitespace and formatting cleanup—primarily trailing blank line removals that recur across 35+ files with identical patterns. While there are some scattered substantive changes (version bump, documentation updates, __func__ additions in PMD config), they represent isolated tweaks that require minimal reasoning. The array trailing-comma removals are minor syntax corrections. High repetition across similar file types reduces cognitive overhead.

Minor attention areas:
- doc/guides/nics/mlx5.rst: Verify device compatibility statements for dv_flow_en, DV flow, and HWS modes are accurate.
- app/test-pmd/config.c: Confirm __func__ usage in error messages is appropriate and consistent.
- Bnxt driver array syntax fixes: Ensure trailing-comma removal does not inadvertently affect compilation or initialization order.

Poem

🐰 A hop, a skip, through trailing lines,
Blank spaces trimmed with subtle signs,
Version blooms from RC to gold—
Twenty-five-point-eleven, bold!
Format fair and syntax bright,
Cleanup carried off just right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title 'app/testpmd: fix incorrect function names in logs' is only partially related to the changeset. While one file (app/test-pmd/config.c) does contain function name improvements in error messages, the vast majority of changes are unrelated formatting fixes (trailing blank lines, newlines, version bumps) across 50+ files.	Revise the title to accurately reflect the full scope: something like 'Formatting cleanup and version bump to 25.11.0' or split into focused PRs for distinct changes.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch series_36816

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ad3a36 and 404897f.

⛔ Files ignored due to path filters (17)

doc/guides/contributing/img/abi_stability_policy.svg is excluded by !**/*.svg
doc/guides/contributing/img/what_is_an_abi.svg is excluded by !**/*.svg
doc/guides/howto/img/flow_bifurcation_overview.svg is excluded by !**/*.svg
doc/guides/howto/img/virtio_user_for_container_networking.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/bond-mode-0.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/bond-mode-1.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/bond-mode-2.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/bond-mode-3.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/bond-mode-4.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/bond-mode-5.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/lcore_var_mem_layout.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/pdcp_functional_overview.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/predictable_snat_1.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/predictable_snat_2.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/rss_queue_assign.svg is excluded by !**/*.svg
doc/guides/prog_guide/img/static_array_mem_layout.svg is excluded by !**/*.svg
doc/guides/sample_app_ug/img/overlay_networking.svg is excluded by !**/*.svg

📒 Files selected for processing (50)

VERSION (1 hunks)
app/test-bbdev/test_vectors/bbdev_null.data (1 hunks)
app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_high_snr.data (1 hunks)
app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_low_snr.data (1 hunks)
app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e34560_sbd_posllr.data (1 hunks)
app/test-bbdev/test_vectors/turbo_dec_c2_k3136_r0_e4920_sbd_negllr_crc24b.data (1 hunks)
app/test-bbdev/test_vectors/turbo_enc_c1_k6144_r0_e18448_crc24a.data (1 hunks)
app/test-bbdev/test_vectors/turbo_enc_c3_k4800_r2_e14412_crc24b.data (1 hunks)
app/test-pmd/config.c (2 hunks)
doc/guides/nics/cxgbe.rst (0 hunks)
doc/guides/nics/ipn3ke.rst (0 hunks)
doc/guides/nics/mlx5.rst (2 hunks)
drivers/event/dlb2/dlb2_iface.c (0 hunks)
drivers/net/bnxt/tf_core/tf_em_common.c (0 hunks)
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_act.c (0 hunks)
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_class.c (0 hunks)
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_defs.h (0 hunks)
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_tbl.c (0 hunks)
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor2_class.c (0 hunks)
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor_class.c (0 hunks)
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_wh_plus_class.c (0 hunks)
drivers/net/gve/base/gve_adminq.c (0 hunks)
drivers/net/gve/gve_rss.c (0 hunks)
drivers/net/gve/gve_rss.h (0 hunks)
drivers/net/hinic/base/hinic_pmd_mbox.c (0 hunks)
drivers/net/hinic/base/hinic_pmd_niccfg.c (0 hunks)
drivers/net/hinic/base/meson.build (0 hunks)
drivers/net/intel/e1000/base/e1000_82575.c (0 hunks)
drivers/net/intel/e1000/base/e1000_mbx.c (0 hunks)
drivers/net/intel/e1000/base/e1000_vf.c (0 hunks)
drivers/net/intel/i40e/base/i40e_adminq.c (0 hunks)
drivers/net/intel/ice/base/ice_flex_pipe.c (0 hunks)
drivers/net/intel/ice/base/ice_hw_autogen.h (0 hunks)
drivers/net/intel/ixgbe/base/ixgbe_dcb_82599.c (0 hunks)
drivers/net/intel/ixgbe/base/ixgbe_x540.h (0 hunks)
drivers/net/mlx5/hws/mlx5dr_buddy.c (0 hunks)
drivers/net/nfp/nfp_ipsec.c (0 hunks)
drivers/net/nfp/nfpcore/nfp_elf.c (0 hunks)
drivers/net/ngbe/base/ngbe_dummy.h (0 hunks)
drivers/net/ngbe/base/ngbe_phy.c (0 hunks)
drivers/net/octeontx/base/octeontx_bgx.h (0 hunks)
drivers/net/txgbe/base/txgbe_dcb.c (0 hunks)
drivers/net/txgbe/base/txgbe_dcb_hw.c (0 hunks)
drivers/net/txgbe/base/txgbe_dummy.h (0 hunks)
drivers/net/txgbe/base/txgbe_eeprom.c (0 hunks)
drivers/net/virtio/virtio_cvq.c (0 hunks)
drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_selftest.c (0 hunks)
drivers/vdpa/mlx5/mlx5_vdpa_event.c (0 hunks)
dts/configurations/tests_config.example.yaml (1 hunks)
license/Linux-syscall-note (0 hunks)

💤 Files with no reviewable changes (39)

drivers/net/gve/base/gve_adminq.c
drivers/net/hinic/base/hinic_pmd_niccfg.c
drivers/net/intel/i40e/base/i40e_adminq.c
drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_selftest.c
drivers/net/txgbe/base/txgbe_dcb_hw.c
drivers/net/ngbe/base/ngbe_dummy.h
drivers/net/hinic/base/hinic_pmd_mbox.c
drivers/net/intel/ice/base/ice_flex_pipe.c
drivers/net/octeontx/base/octeontx_bgx.h
drivers/net/virtio/virtio_cvq.c
drivers/vdpa/mlx5/mlx5_vdpa_event.c
drivers/net/gve/gve_rss.c
doc/guides/nics/ipn3ke.rst
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_tbl.c
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_class.c
drivers/net/intel/e1000/base/e1000_mbx.c
drivers/net/txgbe/base/txgbe_dcb.c
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_wh_plus_class.c
drivers/net/intel/e1000/base/e1000_vf.c
drivers/net/txgbe/base/txgbe_dummy.h
drivers/net/nfp/nfp_ipsec.c
drivers/net/intel/ixgbe/base/ixgbe_x540.h
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_defs.h
drivers/net/intel/e1000/base/e1000_82575.c
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_act.c
drivers/net/hinic/base/meson.build
drivers/net/bnxt/tf_core/tf_em_common.c
drivers/event/dlb2/dlb2_iface.c
license/Linux-syscall-note
drivers/net/nfp/nfpcore/nfp_elf.c
drivers/net/mlx5/hws/mlx5dr_buddy.c
drivers/net/intel/ixgbe/base/ixgbe_dcb_82599.c
drivers/net/ngbe/base/ngbe_phy.c
doc/guides/nics/cxgbe.rst
drivers/net/txgbe/base/txgbe_eeprom.c
drivers/net/gve/gve_rss.h
drivers/net/intel/ice/base/ice_hw_autogen.h
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor2_class.c
drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor_class.c

🔇 Additional comments (14)

dts/configurations/tests_config.example.yaml (1)

17-17: Cosmetic change to commented configuration example.

This change re-adds a commented configuration option with no functional impact, since the line is part of a commented-out section that serves as documentation for the configuration format.

Note: The PR title mentions "app/testpmd: fix incorrect function names in logs," but this file is a configuration example in the dts directory. If this file is incidental to the main PR objective, it may belong in a separate cleanup commit for clarity.

doc/guides/nics/mlx5.rst (2)

691-696: Documentation clarity improved with explicit device compatibility.

The addition of device availability notes ("available for devices older than ConnectX-9") and the rdma-core 24 requirement for DV flow steering provides users with clearer decision points when selecting flow engines. The changes logically integrate with the existing parameter descriptions.

1343-1344: HWS device exclusivity clearly documented.

The clarifications that HWS is "the only mode supporting the flow template async API" and "the only mode supported on device ConnectX-9 and later" provide essential context for users selecting hardware and flow engine configurations. These statements align with the requirements table and flow engine capabilities described earlier in the guide.

app/test-bbdev/test_vectors/turbo_dec_c2_k3136_r0_e4920_sbd_negllr_crc24b.data (1)

677-677: Formatting change looks fine.

This appears to be a trailing newline standardization with no change to the actual expected_status value.

app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_low_snr.data (1)

640-640: LGTM.

End-of-file newline standardization with no semantic changes.

app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e34560_sbd_posllr.data (1)

1222-1222: LGTM.

Consistent end-of-file newline handling across test vectors.

app/test-bbdev/test_vectors/turbo_enc_c3_k4800_r2_e14412_crc24b.data (1)

153-153: LGTM.

End-of-file newline formatting aligns with other test vector files.

VERSION (1)

1-1: Version bump to final release looks correct.

Transitioning from 25.11.0-rc4 to 25.11.0 for the final release.

app/test-bbdev/test_vectors/turbo_enc_c1_k6144_r0_e18448_crc24a.data (1)

158-159: Formatting-only change: newline adjustment for expected_status.

This file modification is purely a formatting adjustment affecting newline handling at end-of-file for the test vector data. The test vector content and expected status value (OK) remain unchanged.

app/test-bbdev/test_vectors/bbdev_null.data (1)

4-5: Formatting-only change: newline adjustment for op_type value.

This file modification is purely a formatting adjustment affecting newline handling for the test vector data. The test vector content and op_type value (RTE_BBDEV_OP_NONE) remain unchanged.

app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_high_snr.data (1)

639-640: Formatting-only change: newline adjustment for expected_status.

This file modification is purely a formatting adjustment affecting newline handling at end-of-file for the test vector data. The test vector configuration, input, output, and expected status value (OK) remain unchanged.

app/test-pmd/config.c (3)

6505-6506: LGTM: Function name added to error message

Good improvement to debugging clarity by prepending the function name using __func__. This follows the existing pattern used in other functions like rx_vlan_strip_set.

6732-6733: LGTM: Function name added to error message

The addition of __func__ improves error message context for debugging. The format string and arguments are correctly aligned.

6505-6506: AI summary contains incorrect function names

The AI summary incorrectly identifies the modified functions as rx_vlan_extend_set and tx_vlan_tpid_set, but the actual function names are:

vlan_extend_set (line 6483)

vlan_tpid_set (line 6720)

Also applies to: 6732-6733

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tmonjalo and others added 4 commits November 30, 2025 15:40

version: 25.11.0

ed95716

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

sourcery-ai bot reviewed Dec 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PWCI] "app/testpmd: fix incorrect function names in logs" #508

[PWCI] "app/testpmd: fix incorrect function names in logs" #508

Uh oh!

ovsrobot commented Dec 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

sourcery-ai bot left a comment

Uh oh!

coderabbitai bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[PWCI] "app/testpmd: fix incorrect function names in logs" #508

Are you sure you want to change the base?

[PWCI] "app/testpmd: fix incorrect function names in logs" #508

Uh oh!

Conversation

ovsrobot commented Dec 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ovsrobot commented Dec 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 1, 2025 •

edited

Loading