[PWCI] "version: 26.03-rc0" #521
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with NVIDIA ConnectX-9, the future devices will support only hardware steering (HWS) flow engine. The software steering options (legacy Verbs and Direct Verbs) have lower performances, and won't be available for new devices. Both flow APIs (sync and async template) will still be supported with the hardware steering flow engine. Fixes: 1b55eeb ("common/mlx5: add ConnectX-9 SuperNIC") Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
The tool ripgrep allows to find files not ending with a line break: rg -Ul '[^\n]\z' The files with a trailing blank lines are shown with this command: rg -Ul '\n\n\z' Files are fixed to end with a single line break. Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Start a new release cycle with empty release notes. Bump version and ABI minor. Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: 0-day Robot <robot@bytheb.org>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate CI to build against DPDK v25.11 ABI and add ABI checks, bump project version/ABI metadata and release notes for 26.03-rc0, refresh assorted documentation/assets/test vectors, and clean up minor trailing-whitespace/style issues across several drivers. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The change to
dts/configurations/tests_config.example.yamlstill leaves the file without a trailing newline; consider adding a newline at EOF to match common style across the tree. - Now that
REF_GIT_TAGin.github/workflows/build.ymlis hard-coded tov25.11, it might be worth centralizing this ABI reference (or clearly tying it toABI_VERSION/VERSION) to reduce the risk of it drifting out of sync on future version bumps.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The change to `dts/configurations/tests_config.example.yaml` still leaves the file without a trailing newline; consider adding a newline at EOF to match common style across the tree.
- Now that `REF_GIT_TAG` in `.github/workflows/build.yml` is hard-coded to `v25.11`, it might be worth centralizing this ABI reference (or clearly tying it to `ABI_VERSION`/`VERSION`) to reduce the risk of it drifting out of sync on future version bumps.
## Individual Comments
### Comment 1
<location> `doc/guides/nics/mlx5.rst:1343-1344` </location>
<code_context>
Faster than software steering (SWS),
-hardware steering (HWS) is the only mode supporting the flow template async API.
+hardware steering (HWS) is the only mode supporting the flow template async API,
+and the only mode supported on device ConnectX-9 and later.
Flow rules are managed by the hardware,
</code_context>
<issue_to_address>
**nitpick (typo):** Clarify wording around hardware steering support on ConnectX-9 and later.
Consider rephrasing to "on ConnectX-9 and later devices" (or similar) for better grammatical clarity.
```suggestion
hardware steering (HWS) is the only mode supporting the flow template async API,
and is the only mode supported on ConnectX-9 and later devices.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
WalkthroughThis PR applies version bumps (ABI_VERSION 26.0→26.1, VERSION 25.11.0-rc4→26.03.0-rc0), updates CI workflows with ABI checks and Git tags, adds a release notes template for v26.03, adjusts test vectors and documentation, and removes trailing whitespace across driver files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/test-bbdev/test_vectors/bbdev_null.data (1)
5-5: Normalize EOF newline — LGTMEOF newline added; consistent with POSIX editors/tools.
Consider adding a repo-level .editorconfig with insert_final_newline = true to keep this consistent.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (17)
doc/guides/contributing/img/abi_stability_policy.svgis excluded by!**/*.svgdoc/guides/contributing/img/what_is_an_abi.svgis excluded by!**/*.svgdoc/guides/howto/img/flow_bifurcation_overview.svgis excluded by!**/*.svgdoc/guides/howto/img/virtio_user_for_container_networking.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/bond-mode-0.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/bond-mode-1.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/bond-mode-2.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/bond-mode-3.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/bond-mode-4.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/bond-mode-5.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/lcore_var_mem_layout.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/pdcp_functional_overview.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/predictable_snat_1.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/predictable_snat_2.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/rss_queue_assign.svgis excluded by!**/*.svgdoc/guides/prog_guide/img/static_array_mem_layout.svgis excluded by!**/*.svgdoc/guides/sample_app_ug/img/overlay_networking.svgis excluded by!**/*.svg
📒 Files selected for processing (53)
.github/workflows/build.yml(2 hunks)ABI_VERSION(1 hunks)VERSION(1 hunks)app/test-bbdev/test_vectors/bbdev_null.data(1 hunks)app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_high_snr.data(1 hunks)app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_low_snr.data(1 hunks)app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e34560_sbd_posllr.data(1 hunks)app/test-bbdev/test_vectors/turbo_dec_c2_k3136_r0_e4920_sbd_negllr_crc24b.data(1 hunks)app/test-bbdev/test_vectors/turbo_enc_c1_k6144_r0_e18448_crc24a.data(1 hunks)app/test-bbdev/test_vectors/turbo_enc_c3_k4800_r2_e14412_crc24b.data(1 hunks)doc/guides/nics/cxgbe.rst(0 hunks)doc/guides/nics/ipn3ke.rst(0 hunks)doc/guides/nics/mlx5.rst(2 hunks)doc/guides/rel_notes/index.rst(1 hunks)doc/guides/rel_notes/release_26_03.rst(1 hunks)drivers/event/dlb2/dlb2_iface.c(0 hunks)drivers/net/bnxt/tf_core/tf_em_common.c(0 hunks)drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_act.c(0 hunks)drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_class.c(0 hunks)drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_defs.h(0 hunks)drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_tbl.c(0 hunks)drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor2_class.c(0 hunks)drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor_class.c(0 hunks)drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_wh_plus_class.c(0 hunks)drivers/net/gve/base/gve_adminq.c(0 hunks)drivers/net/gve/gve_rss.c(0 hunks)drivers/net/gve/gve_rss.h(0 hunks)drivers/net/hinic/base/hinic_pmd_mbox.c(0 hunks)drivers/net/hinic/base/hinic_pmd_niccfg.c(0 hunks)drivers/net/hinic/base/meson.build(0 hunks)drivers/net/intel/e1000/base/e1000_82575.c(0 hunks)drivers/net/intel/e1000/base/e1000_mbx.c(0 hunks)drivers/net/intel/e1000/base/e1000_vf.c(0 hunks)drivers/net/intel/i40e/base/i40e_adminq.c(0 hunks)drivers/net/intel/ice/base/ice_flex_pipe.c(0 hunks)drivers/net/intel/ice/base/ice_hw_autogen.h(0 hunks)drivers/net/intel/ixgbe/base/ixgbe_dcb_82599.c(0 hunks)drivers/net/intel/ixgbe/base/ixgbe_x540.h(0 hunks)drivers/net/mlx5/hws/mlx5dr_buddy.c(0 hunks)drivers/net/nfp/nfp_ipsec.c(0 hunks)drivers/net/nfp/nfpcore/nfp_elf.c(0 hunks)drivers/net/ngbe/base/ngbe_dummy.h(0 hunks)drivers/net/ngbe/base/ngbe_phy.c(0 hunks)drivers/net/octeontx/base/octeontx_bgx.h(0 hunks)drivers/net/txgbe/base/txgbe_dcb.c(0 hunks)drivers/net/txgbe/base/txgbe_dcb_hw.c(0 hunks)drivers/net/txgbe/base/txgbe_dummy.h(0 hunks)drivers/net/txgbe/base/txgbe_eeprom.c(0 hunks)drivers/net/virtio/virtio_cvq.c(0 hunks)drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_selftest.c(0 hunks)drivers/vdpa/mlx5/mlx5_vdpa_event.c(0 hunks)dts/configurations/tests_config.example.yaml(1 hunks)license/Linux-syscall-note(0 hunks)
💤 Files with no reviewable changes (39)
- drivers/net/hinic/base/hinic_pmd_mbox.c
- drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_defs.h
- drivers/net/gve/base/gve_adminq.c
- drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_selftest.c
- drivers/net/virtio/virtio_cvq.c
- drivers/net/intel/ixgbe/base/ixgbe_dcb_82599.c
- drivers/net/mlx5/hws/mlx5dr_buddy.c
- drivers/net/txgbe/base/txgbe_eeprom.c
- doc/guides/nics/cxgbe.rst
- drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_class.c
- drivers/net/intel/i40e/base/i40e_adminq.c
- drivers/net/txgbe/base/txgbe_dcb.c
- drivers/net/txgbe/base/txgbe_dcb_hw.c
- drivers/net/intel/e1000/base/e1000_vf.c
- drivers/net/intel/ice/base/ice_flex_pipe.c
- drivers/net/ngbe/base/ngbe_dummy.h
- drivers/net/hinic/base/hinic_pmd_niccfg.c
- drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_act.c
- drivers/vdpa/mlx5/mlx5_vdpa_event.c
- drivers/net/nfp/nfp_ipsec.c
- drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_tbl.c
- drivers/net/ngbe/base/ngbe_phy.c
- drivers/net/bnxt/tf_core/tf_em_common.c
- drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_wh_plus_class.c
- license/Linux-syscall-note
- drivers/net/octeontx/base/octeontx_bgx.h
- drivers/net/hinic/base/meson.build
- drivers/net/intel/e1000/base/e1000_mbx.c
- drivers/net/gve/gve_rss.h
- drivers/net/intel/e1000/base/e1000_82575.c
- drivers/net/gve/gve_rss.c
- drivers/net/intel/ice/base/ice_hw_autogen.h
- drivers/net/txgbe/base/txgbe_dummy.h
- doc/guides/nics/ipn3ke.rst
- drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor2_class.c
- drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor_class.c
- drivers/net/nfp/nfpcore/nfp_elf.c
- drivers/event/dlb2/dlb2_iface.c
- drivers/net/intel/ixgbe/base/ixgbe_x540.h
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Sourcery review
🔇 Additional comments (16)
VERSION (1)
1-1: Version bump is correctly set and aligns with release metadata.The version string
26.03.0-rc0follows the expected calendar-based scheme (2026-Q3), matches the ABI_VERSION increment (26.0→26.1), and is consistent with the release notes template introduced inrelease_26_03.rst.dts/configurations/tests_config.example.yaml (1)
1-17: EOF formatting is corrected; no content changes.The addition of a trailing newline aligns with standard file formatting practices and is consistent with the PR's general whitespace cleanup scope.
.github/workflows/build.yml (2)
15-15: REF_GIT_TAG set to v25.11 for ABI compatibility baseline.This tag is used (line 130) as part of the cache key for ABI reference builds, enabling the workflow to compare against the v25.11 release. Verify that v25.11 is the intended baseline for ABI compatibility checks.
99-99: ABI check enabled for ubuntu-22.04 gcc matrix.Adding
abito the checks set enables ABI compatibility validation during the build. This aligns with the ABI_VERSION increment (26.0 → 26.1) and the release notes statement that there are no breaking ABI changes relative to 25.11.ABI_VERSION (1)
1-1: ABI version correctly incremented to 26.1.The change from 26.0 to 26.1 signals a minor ABI version bump compatible with the previous release, consistent with the release notes' statement of backward compatibility with 25.11.
doc/guides/nics/mlx5.rst (2)
691-702: Documentation clarity improved for flow steering hardware support.The mlx5 driver documentation now explicitly clarifies device support boundaries:
- Value 0 and Value 1 (
dv_flow_en) are limited to devices older than ConnectX-9- Hardware Steering (HWS) is stated as the only supported mode on ConnectX-9 and later
This aligns with the addition of ConnectX-9 to the supported devices table and aids users in selecting appropriate configurations for their hardware.
1343-1344: HWS hardware support clarification is consistent.The statement that hardware steering is "the only mode supported on device ConnectX-9 and later" is consistent with the device capability updates and aids in understanding device-mode compatibility.
doc/guides/rel_notes/index.rst (1)
11-11: Release 26.03 correctly added to release notes index.The
release_26_03entry is properly positioned at the top of the toctree (most recent release first) and correctly references the new release notes file.doc/guides/rel_notes/release_26_03.rst (2)
1-103: Release notes template is well-structured with clear guidance.The
release_26_03.rstfile provides a comprehensive template with appropriate sections (New Features, API Changes, ABI Changes, Known Issues, Tested Platforms) and clear inline guidance for maintainers. The single substantive entry at line 103—"No ABI change that would break compatibility with 25.11"—aligns with the ABI version increment (26.0→26.1) and CI workflow changes (REF_GIT_TAG=v25.11).
18-21: Build and verification instructions are helpful.The included instructions for building and viewing the documentation locally (lines 18–21) aid contributors in validating their changes before submission.
app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_high_snr.data (1)
639-640: EOF newline on expected_status — OKFormatting-only; no semantic changes.
app/test-bbdev/test_vectors/turbo_dec_c2_k3136_r0_e4920_sbd_negllr_crc24b.data (1)
676-677: EOF newline on expected_status — OKPure formatting; safe.
app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e34560_sbd_posllr.data (1)
1221-1222: EOF newline on expected_status — OKFormatting-only; tests unchanged.
app/test-bbdev/test_vectors/turbo_dec_c1_k6144_r0_e10376_crc24b_sbd_negllr_low_snr.data (1)
639-640: EOF newline on expected_status — OKNo behavior impact.
app/test-bbdev/test_vectors/turbo_enc_c3_k4800_r2_e14412_crc24b.data (1)
152-153: EOF newline on expected_status — OKConsistent with the rest of the vectors.
app/test-bbdev/test_vectors/turbo_enc_c1_k6144_r0_e18448_crc24a.data (1)
158-159: Standardize expected_status token ("OK")Change from "-OK" to plain "OK" is correct. The parser's
parse_expected_status()function expects plain "OK" as a valid token, and no remaining "-OK" entries exist in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is an auto submission for "version: 26.03-rc0".
See "http://patchwork.dpdk.org/project/dpdk/list/?series=36833" for details.
Summary by Sourcery
Prepare the tree for the 26.03-rc0 release by updating version metadata, artifacts, and documentation, and tightening CI checks against the 25.11 reference tag.
New Features:
Enhancements:
Build:
Documentation:
Tests:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.