[PWCI] "Fix errors with updated MSVC in github actions" #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with NVIDIA ConnectX-9, the future devices will support only hardware steering (HWS) flow engine. The software steering options (legacy Verbs and Direct Verbs) have lower performances, and won't be available for new devices. Both flow APIs (sync and async template) will still be supported with the hardware steering flow engine. Fixes: 1b55eeb ("common/mlx5: add ConnectX-9 SuperNIC") Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
The tool ripgrep allows to find files not ending with a line break: rg -Ul '[^\n]\z' The files with a trailing blank lines are shown with this command: rg -Ul '\n\n\z' Files are fixed to end with a single line break. Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Within github actions, the following error can be reported: ...\rte_rcu_qsbr.h(566): error C2220: the following warning is treated as an error ...\rte_rcu_qsbr.h(566): warning C4319: '~': zero extending 'unsigned long' to 'uint64_t' of greater size To fix this, replace the "1UL" with RTE_BIT64 to force a 64-bit value on all platforms. Fixes: 64994b5 ("rcu: add RCU library supporting QSBR mechanism") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Signed-off-by: 0-day Robot <robot@bytheb.org>
Disable warning about "zero extending 'unsigned long' to 'u64' of greater size" in base code builds. Cc: stable@dpdk.org Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Signed-off-by: 0-day Robot <robot@bytheb.org>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts one RCU bitmask operation to use the RTE_BIT64 helper for MSVC compatibility, adds a new MSVC warning suppression flag for the ICE driver build, and cleans up a large number of trailing blank lines and file-end formatting issues across drivers, docs, test vectors, and licenses to fix build/test issues with newer MSVC and tooling. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Instead of globally disabling MSVC warning 4319 in
drivers/net/intel/ice/base/meson.build, consider fixing the specific zero-extension sites with explicit casts so the intent is clear and the warning remains available for unintended truncation/extension issues. - This PR combines a functional change (
bmap &= ~RTE_BIT64(j);) with a large number of trailing-whitespace/newline cleanups across many files; consider splitting mechanical formatting changes into a separate patch to keep the MSVC-related fix focused and easier to review.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of globally disabling MSVC warning 4319 in `drivers/net/intel/ice/base/meson.build`, consider fixing the specific zero-extension sites with explicit casts so the intent is clear and the warning remains available for unintended truncation/extension issues.
- This PR combines a functional change (`bmap &= ~RTE_BIT64(j);`) with a large number of trailing-whitespace/newline cleanups across many files; consider splitting mechanical formatting changes into a separate patch to keep the MSVC-related fix focused and easier to review.
## Individual Comments
### Comment 1
<location> `doc/guides/nics/mlx5.rst:1343-1344` </location>
<code_context>
Faster than software steering (SWS),
-hardware steering (HWS) is the only mode supporting the flow template async API.
+hardware steering (HWS) is the only mode supporting the flow template async API,
+and the only mode supported on device ConnectX-9 and later.
Flow rules are managed by the hardware,
</code_context>
<issue_to_address>
**issue (typo):** Clarify grammar in "supported on device ConnectX-9 and later".
Consider rephrasing to “supported on ConnectX-9 and later devices” or “supported on devices ConnectX-9 and later” to improve grammar and readability.
```suggestion
hardware steering (HWS) is the only mode supporting the flow template async API,
and the only mode supported on ConnectX-9 and later devices.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
WalkthroughVersion bump from 25.11.0-rc4 to final 25.11.0 release with extensive formatting cleanup (trailing blank line removals across drivers and libraries), minor documentation clarifications, and a macro refactoring in RCU code. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~18 minutes Areas requiring attention:
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (17)
📒 Files selected for processing (51)
💤 Files with no reviewable changes (39)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-submission for "http://patchwork.dpdk.org/project/dpdk/list/?series=36842"
Summary by Sourcery
Fix build and warning issues with newer MSVC and tidy up minor code style issues across drivers and docs.
Bug Fixes:
Enhancements:
Summary by CodeRabbit
New Features
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.