Implement id ranges for ctl:ruleRemoveTargetById #2430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMPORTANT: SecDefaultAction specified on a child configuration will overwrite the ones specified on the parent; Previously it was concatenating.
Generals organization on the Action class
Previously, ModSecurity inconsistently used RuleId, int and double for rule id variables in different places.
In C++11, string data is always null-terminated[1], and can be freely modified[2]. [1] https://stackoverflow.com/questions/6077189/will-stdstring-always-be-null-terminated-in-c11 [2] https://stackoverflow.com/questions/38875623/is-it-permitted-to-modify-the-internal-stdstring-buffer-returned-by-operator
Using the references on key and collection as shared pointers
Making the code more readable.
On `Use std::shared_ptr for variable resolution` @wgh changes VariableValue to be a shared_ptr. As shared pointer, the copy on AnchoredVariable is no longer necessary. The copy was removed along with the copy constructor.
Last compute at the last minute, if needed.
i/o operations are expensive. Making sure that they were not being executed/printed more than necessary.
zimmerle
force-pushed
the
v3/dev/3.1-experimental
branch
3 times, most recently
from
4e6f485 to
b4a8fa9
Compare
zimmerle
force-pushed
the
v3/dev/3.1-experimental
branch
2 times, most recently
from
33752b3 to
abf59f4
Compare
Contributor
|
On branch v3/dev/pull_2430 doing some QA testing. |
zimmerle
force-pushed
the
v3/dev/3.1-experimental
branch
3 times, most recently
from
1632d3b to
7aceb99
Compare
|
What release was this actually included in? I don't see the defect listed in 3.0.4 and 3.1.0 hasn't been released yet. |
Member
I'm not sure it was merged into any main branch. As you can see above, the original author pushed this into a development branch. Since then there are many changes in the code, so I'm not sure we can pick up this in this form. Probably someone needs to rewrite this feature... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.