feat: add optional smoke test step to docker-build workflow#263
Open
DeepDiver1975 wants to merge 3 commits intomasterfrom
Open
feat: add optional smoke test step to docker-build workflow#263DeepDiver1975 wants to merge 3 commits intomasterfrom
DeepDiver1975 wants to merge 3 commits intomasterfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace unquoted ARGS string with bash array to prevent word-splitting - Add description to smoke-test-port input documenting host==container port - Fix poll loop: pre-declare STATUS, check after loop, accurate timing - Guard against empty CID after docker run - Add comment clarifying smoke-test-entrypoint-cmd is an entrypoint override Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a smoke-test-cmd input to docker-build.yml for images that have no HTTP endpoint (e.g. base images). The command runs inside the container and must exit 0. Wires it up in main.yml to assert the Ubuntu version matches the matrix tag via /etc/os-release. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-build.yml:smoke-test-port,smoke-test-url,smoke-test-env,smoke-test-entrypoint-cmd,smoke-test-version-jqsmoke-test-urlis empty (default), theSmoke teststep is skipped — no change for existing callers127.0.0.1:5000/image:tempfrom the local registry, polls the URL every 2s for up to 60s, and fails with container logs on timeoutsmoke-test-entrypoint-cmdoverrides the entrypoint to/bin/sh -c "<cmd>"for images that need an init step (e.g. oCIS:ocis init || true; exec ocis server)smoke-test-version-jqoptionally asserts a jq-extracted field from the response JSON equalsdocker-tagenv:vars in therun:block — no inline expression interpolation🤖 Generated with Claude Code