fix: handle curl network errors in smoke test polling loop#265
Merged
DeepDiver1975 merged 1 commit intomasterfrom May 6, 2026
Merged
fix: handle curl network errors in smoke test polling loop#265DeepDiver1975 merged 1 commit intomasterfrom
DeepDiver1975 merged 1 commit intomasterfrom
Conversation
With bash -e -o pipefail, a curl exit code 56 (CURLE_RECV_ERROR) causes the polling loop to abort immediately on the first iteration. This happens because Docker's userland proxy binds the host port and accepts TCP connections right away, but then immediately resets them while the container's init scripts are still running. The result is a connection reset rather than ECONNREFUSED, so curl exits non-zero. Add || STATUS="000" so connection-level errors are treated as "not ready yet" and the loop continues polling until the 60 s timeout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The smoke test step runs under
bash -e -o pipefail. When Docker starts a container with-p 8080:8080 -d, the userland proxy binds the host port immediately and accepts TCP connections — before Apache inside the container is ready. While ownCloud's first-run SQLite installation is running, the proxy accepts the connection then immediately resets it. curl exits with code 56 (CURLE_RECV_ERROR— "failure in receiving network data"), which is non-zero and causes bash to abort the entire step withset -e.The EXIT trap then runs
docker stopwith its default 10 s grace period, producing the characteristic ~10 s gap betweenPolling …and the##[error]Process completed with exit code 56.seen in CI.Fix
Add
|| STATUS="000"so curl network errors (exit codes 7, 56, etc.) are caught and treated as "not ready yet", allowing the loop to continue polling for the full 60 s.Test plan
🤖 Generated with Claude Code