chore: post-review improvements#3
Merged
DeepDiver1975 merged 1 commit intomasterfrom May 8, 2026
Merged
Conversation
- Dockerfile: add VERSION guard and tighten sha256sum grep pattern - Add .dockerignore to reduce build context - README: update release workflow to use PRs instead of direct push Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-review fixes from final code review:
VERSIONguard (fails fast with a clear error if--build-arg VERSIONis omitted) and tightensha256sumgrep to an exact pattern match (^[0-9a-f]{64} web\.tar\.gz$).dockerignore: exclude.git,.github,docs/,README.md, etc. from the build context to reduce context size and prevent spurious cache invalidationTest plan
docker buildwithout--build-arg VERSIONprints a clear error and exits 1🤖 Generated with Claude Code