Skip to content

Conversation

@VicDeo
Copy link
Member

@VicDeo VicDeo commented Oct 8, 2015

Fixes #4

@VicDeo
Copy link
Member Author

VicDeo commented Oct 8, 2015

@DeepDiver1975

@DeepDiver1975
Copy link
Member

Nice - THX

@LukasReschke mind testing the two options regarding file name length on mac? THX

@PVince81
Copy link

PVince81 commented Jul 4, 2017

@tomneedham I heard you have a Mac ?

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #6 into master will increase coverage by 2.44%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   84.34%   86.79%   +2.44%     
==========================================
  Files           1        2       +1     
  Lines         115      159      +44     
==========================================
+ Hits           97      138      +41     
- Misses         18       21       +3
Impacted Files Coverage Δ
src/TarHeader.php 100% <100%> (ø)
src/TarStreamer.php 79.61% <75%> (-4.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ab021...6332cb6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #6 into master will increase coverage by 2.44%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   84.34%   86.79%   +2.44%     
==========================================
  Files           1        2       +1     
  Lines         115      159      +44     
==========================================
+ Hits           97      138      +41     
- Misses         18       21       +3
Impacted Files Coverage Δ
src/TarHeader.php 100% <100%> (ø)
src/TarStreamer.php 79.61% <75%> (-4.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ab021...6332cb6. Read the comment docs.

@VicDeo VicDeo requested a review from DeepDiver1975 February 8, 2019 18:09
@DeepDiver1975 DeepDiver1975 merged commit 2d99636 into master Feb 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the L-header branch February 11, 2019 13:56
@PVince81
Copy link

@VicDeo @DeepDiver1975 do we need to bump tarstreamer in core or wait for dependabot to find it ?

@DeepDiver1975
Copy link
Member

dependabot shall do this - it is it's job to do so ... but we need to tag a version .... will take care

@DeepDiver1975
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants