[FEATURE REQUEST] Create a link over a space #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

joragua wants to merge 8 commits into master from feature/create_a_link_over_a_space

+2,067 −34

CHANGELOG.md

-Original file line number
+Diff line change
@@ Expand Up / @@ -47,6 +47,7 @@ ownCloud admins and users. @@
     * Bugfix - Conventional commits' action ignores SBOM automatic commits: [#4808](https://github.com/owncloud/android/pull/4808)
     * Change - Migrate tests to the new kotlinx-coroutines-test API: [#4710](https://github.com/owncloud/android/issues/4710)
     * Change - Increase rating dialog delay: [#4744](https://github.com/owncloud/android/pull/4744)
+    * Change - Resource leak in CopyAndUploadContentUrisTask: [#4797](https://github.com/owncloud/android/issues/4797)
     * Change - Stream handling and double-close in UploadFileFromContentUriWorker: [#4798](https://github.com/owncloud/android/issues/4798)
     * Change - Update actions dependencies to be compliant with Node24 requirements: [#4804](https://github.com/owncloud/android/pull/4804)
     * Enhancement - Show members of a space: [#4612](https://github.com/owncloud/android/issues/4612)
@@ Expand All / @@ -56,6 +57,7 @@ ownCloud admins and users. @@
     * Enhancement - Remove a space member: [#4725](https://github.com/owncloud/android/issues/4725)
     * Enhancement - Workflow to build APK: [#4751](https://github.com/owncloud/android/pull/4751)
     * Enhancement - List links over a space: [#4752](https://github.com/owncloud/android/issues/4752)
+    * Enhancement - Add a public link over a space: [#4753](https://github.com/owncloud/android/issues/4753)
     * Enhancement - Copy permanent link of a space: [#4758](https://github.com/owncloud/android/issues/4758)
     * Enhancement - Workflow to check Conventional Commits: [#4759](https://github.com/owncloud/android/pull/4759)
     * Enhancement - QA Content Provider: [#4776](https://github.com/owncloud/android/pull/4776)
@@ Expand Down Expand Up / @@ -116,6 +118,15 @@ ownCloud admins and users. @@
        https://github.com/owncloud/android/pull/4744
+    * Change - Resource leak in CopyAndUploadContentUrisTask: [#4797](https://github.com/owncloud/android/issues/4797)
+       Input and output streams have been closed per URI iteration using
+       try-with-resources to prevent file descriptor and memory leaks when copying
+       multiple content URIs.
+       https://github.com/owncloud/android/issues/4797
+       https://github.com/owncloud/android/pull/4806
     * Change - Stream handling and double-close in UploadFileFromContentUriWorker: [#4798](https://github.com/owncloud/android/issues/4798)
        Both the content resolver input stream and the file output stream from
@@ Expand Down Expand Up / @@ -200,6 +211,14 @@ ownCloud admins and users. @@
        https://github.com/owncloud/android/issues/4752
        https://github.com/owncloud/android/pull/4783
+    * Enhancement - Add a public link over a space: [#4753](https://github.com/owncloud/android/issues/4753)
+       A new option to add public links over a space has been added. It will be only
+       visible for users with proper permissions.
+       https://github.com/owncloud/android/issues/4753
+       https://github.com/owncloud/android/pull/4794
     * Enhancement - Copy permanent link of a space: [#4758](https://github.com/owncloud/android/issues/4758)
        A new option to copy and share the permanent link of a space has been added next
@@ Expand Down @@

changelog/unreleased/4794

-Original file line number
+Diff line change
@@ -0,0 +1,6 @@
+    Enhancement: Add a public link over a space
+    A new option to add public links over a space has been added. It will be only visible for users with proper permissions.
+    https://github.com/owncloud/android/issues/4753
+    https://github.com/owncloud/android/pull/4794

owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/RemoteDataSourceModule.kt

-Original file line number
+Diff line change
@@ Expand Up @@
     import com.owncloud.android.data.capabilities.datasources.mapper.RemoteCapabilityMapper
     import com.owncloud.android.data.files.datasources.RemoteFileDataSource
     import com.owncloud.android.data.files.datasources.implementation.OCRemoteFileDataSource
+    import com.owncloud.android.data.links.datasources.RemoteLinksDataSource
+    import com.owncloud.android.data.links.datasources.implementation.OCRemoteLinksDataSource
     import com.owncloud.android.data.members.datasources.RemoteMembersDataSource
     import com.owncloud.android.data.members.datasources.implementation.OCRemoteMembersDataSource
     import com.owncloud.android.data.oauth.datasources.RemoteOAuthDataSource
@@ Expand Down Expand Up / @@ -78,6 +80,7 @@ val remoteDataSourceModule = module { @@
         singleOf(::OCRemoteAuthenticationDataSource) bind RemoteAuthenticationDataSource::class
         singleOf(::OCRemoteCapabilitiesDataSource) bind RemoteCapabilitiesDataSource::class
         singleOf(::OCRemoteFileDataSource) bind RemoteFileDataSource::class
+        singleOf(::OCRemoteLinksDataSource) bind RemoteLinksDataSource::class
         singleOf(::OCRemoteMembersDataSource) bind RemoteMembersDataSource::class
         singleOf(::OCRemoteOAuthDataSource) bind RemoteOAuthDataSource::class
         singleOf(::OCRemoteRolesDataSource) bind RemoteRolesDataSource::class
@@ Expand Down @@

owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/RepositoryModule.kt

-Original file line number
+Diff line change
@@ Expand Up @@
     import com.owncloud.android.data.capabilities.repository.OCCapabilityRepository
     import com.owncloud.android.data.files.repository.OCFileRepository
     import com.owncloud.android.data.folderbackup.repository.OCFolderBackupRepository
+    import com.owncloud.android.data.links.repository.OCLinksRepository
     import com.owncloud.android.data.members.repository.OCMembersRepository
     import com.owncloud.android.data.oauth.repository.OCOAuthRepository
     import com.owncloud.android.data.roles.repository.OCRolesRepository
@@ Expand All @@
     import com.owncloud.android.domain.automaticuploads.FolderBackupRepository
     import com.owncloud.android.domain.capabilities.CapabilityRepository
     import com.owncloud.android.domain.files.FileRepository
+    import com.owncloud.android.domain.links.LinksRepository
     import com.owncloud.android.domain.members.MembersRepository
     import com.owncloud.android.domain.roles.RolesRepository
     import com.owncloud.android.domain.server.ServerInfoRepository
@@ Expand All / @@ -63,6 +65,7 @@ val repositoryModule = module { @@
         factoryOf(::OCCapabilityRepository) bind CapabilityRepository::class
         factoryOf(::OCFileRepository) bind FileRepository::class
         factoryOf(::OCFolderBackupRepository) bind FolderBackupRepository::class
+        factoryOf(::OCLinksRepository) bind LinksRepository::class
         factoryOf(::OCMembersRepository) bind MembersRepository::class
         factoryOf(::OCOAuthRepository) bind OAuthRepository::class
         factoryOf(::OCRolesRepository) bind RolesRepository::class
@@ Expand Down @@

owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/UseCaseModule.kt

-Original file line number
+Diff line change
@@ Expand Up @@
     import com.owncloud.android.domain.files.usecases.SortFilesUseCase
     import com.owncloud.android.domain.files.usecases.SortFilesWithSyncInfoUseCase
     import com.owncloud.android.domain.files.usecases.UpdateAlreadyDownloadedFilesPathUseCase
+    import com.owncloud.android.domain.links.usecases.AddLinkUseCase
     import com.owncloud.android.domain.members.usecases.AddMemberUseCase
     import com.owncloud.android.domain.members.usecases.EditMemberUseCase
     import com.owncloud.android.domain.members.usecases.RemoveMemberUseCase
@@ Expand Down Expand Up / @@ -316,4 +317,7 @@ val useCaseModule = module { @@
         factoryOf(::EditMemberUseCase)
         factoryOf(::RemoveMemberUseCase)
         factoryOf(::SearchMembersUseCase)
+        // Links
+        factoryOf(::AddLinkUseCase)
     }

owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/ViewModelModule.kt

-Original file line number
+Diff line change
@@ Expand Up / @@ -7,7 +7,7 @@ @@
      * @author David Crespo Ríos
      * @author Jorge Aguado Recio
      *
-     * Copyright (C) 2025 ownCloud GmbH.
+     * Copyright (C) 2026 ownCloud GmbH.
      *
      * This program is free software: you can redistribute it and/or modify
      * it under the terms of the GNU General Public License version 2,
@@ Expand Down Expand Up @@
     import com.owncloud.android.presentation.settings.security.SettingsSecurityViewModel
     import com.owncloud.android.presentation.sharing.ShareViewModel
     import com.owncloud.android.presentation.spaces.SpacesListViewModel
+    import com.owncloud.android.presentation.spaces.links.SpaceLinksViewModel
     import com.owncloud.android.presentation.spaces.members.SpaceMembersViewModel
     import com.owncloud.android.presentation.transfers.TransfersViewModel
     import com.owncloud.android.ui.ReceiveExternalFilesViewModel
@@ Expand Down Expand Up / @@ -85,6 +86,7 @@ val viewModelModule = module { @@
         viewModelOf(::SettingsSecurityViewModel)
         viewModelOf(::SettingsVideoUploadsViewModel)
         viewModelOf(::SettingsViewModel)
+        viewModelOf(::SpaceLinksViewModel)
         viewModelOf(::SpaceMembersViewModel)
         viewModelOf(::FileOperationsViewModel)
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE REQUEST] Create a link over a space #4794

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

[FEATURE REQUEST] Create a link over a space #4794

Are you sure you want to change the base?

[FEATURE REQUEST] Create a link over a space #4794

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!