Remove tz none #665
Closed
Remove tz none #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this option causes TimeZoneService to request the "FLOATING.ics" timezone file from the server which is returned with a 404 error (whose error text is parsed as a vcalendar...). What does "None" even mean in context of a timezone? Seems like something that shouldn't be there.
|
@wrexroad, thanks for your PR! By analyzing the annotation information on this pull request, we identified @georgehrke, @MathieuSchopfer and @raghunayyar to be potential reviewers |
Contributor
|
Floating timezones has other benefits. It "travels" with you. Removing it completely is no solution 👎 |
Contributor
Author
|
Ah ha! I didn't fully appreciate what floating was supposed to do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #664
Looking at Mozilla's ical.js, it looks like they intended "floating" to indicate the local timezone, not no timezone. Since the local timezone is already automatically detected and selected it makes sense to just remove the "None" options.