fix: process phpinfo() in cli mode as well#199
Merged
DeepDiver1975 merged 1 commit intomasterfrom Jun 13, 2024
Merged
Conversation
DeepDiver1975
force-pushed
the
fix/phpinfo-cli
branch
4 times, most recently
from
9c949e0 to
1986c49
Compare
Contributor
|
Maybe you could simplify the code by calling phpinfo without credits. |
jvillafanez
reviewed
Jun 12, 2024
DeepDiver1975
force-pushed
the
fix/phpinfo-cli
branch
from
1986c49 to
b18442b
Compare
jvillafanez
approved these changes
Jun 13, 2024
Member
jvillafanez
left a comment
jvillafanez
left a comment
There was a problem hiding this comment.
just tiny detail, but it's ok to skip
lib/ReportDataCollector.php
Outdated
| return $result; | ||
| private function getPhpInfoDetailArray(): array { | ||
| $p = new PHPInfo(); | ||
| $d = $p->load(); |
Member
There was a problem hiding this comment.
return $p->parsePhpInfo(); seems better now.
DeepDiver1975
force-pushed
the
fix/phpinfo-cli
branch
from
b18442b to
0f5fa8a
Compare
|
This was referenced Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.