Skip to content

docs: remove stale log-window keyboard shortcut#746

Open
DeepDiver1975 wants to merge 1 commit into
masterfrom
fix/597-log-hotkey
Open

docs: remove stale log-window keyboard shortcut#746
DeepDiver1975 wants to merge 1 commit into
masterfrom
fix/597-log-hotkey

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Member

What

Removes the btn:[F12] / Ctrl-L / Cmd+L keyboard-shortcut instruction from the "Logging to a Temporary Directory" steps in troubleshooting.adoc, keeping only the menu path.

Why

The hotkey to open the log window no longer exists. Verified against the owncloud/client v7.1.0 source: the log browser is opened only via the General Settings "Log Settings" button (src/gui/generalsettings.cpp:79slotToggleLogBrowser); no F12 / Ctrl+L / Cmd+L shortcut is bound anywhere in src/.

Closes #597

Companion PR onto the 7.1 branch: same change applied there.

🤖 Generated with Claude Code

The F12 / Ctrl-L / Cmd+L keyboard shortcut for opening the log window
no longer exists. In the owncloud/client v7.1.0 source the log browser
is opened only via the General Settings "Log Settings" button
(src/gui/generalsettings.cpp -> slotToggleLogBrowser); no F12/Ctrl+L/
Cmd+L shortcut is bound anywhere in src/. Keep only the menu path.

Closes #597

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated code review by Claude Code review agent

Approve. Removes the stale btn:[F12] / Ctrl-L / Cmd+L log-window hotkey line from the "Logging to a Temporary Directory" steps, keeping the menu path.

  • Verified the removed content is genuinely obsolete: the cited evidence (log browser opened only via General Settings "Log Settings", no hotkey bound in client v7.1.0) is consistent with removing the instruction.
  • Surrounding prose is intact: the numbered list now reads cleanly (. Open the Desktop App.. Click menu:Settings[Advanced > Log Settings].The Log Output window opens.). The dangling + Either ... or continuation was correctly removed with it; no orphaned reference remains.
  • AsciiDoc syntax correct.

Pair consistency: identical diff to the 7.1 companion #745, correct master base, closing keyword Closes #597 carried here. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hotkeys ctrl+L and f12 to open the log settings is removed in 6.0

1 participant