Skip to content

Fix missing image (10.11 only)#1005

Merged
mmattel merged 1 commit into10.11from
fix_missing_image
Jun 16, 2023
Merged

Fix missing image (10.11 only)#1005
mmattel merged 1 commit into10.11from
fix_missing_image

Conversation

@mmattel
Copy link
Copy Markdown
Contributor

@mmattel mmattel commented Jun 15, 2023

This is a 10.11 fix ony.

For what ever reason, this image was missing and another one was not used. Maybe an issue from earlier times.

@mmattel mmattel added the documentation Improvements or additions to documentation label Jun 15, 2023
@mmattel mmattel requested review from EParzefall and phil-davis June 15, 2023 16:14
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core release notes say that
Enhancement - Persistent major file version workflow: #40531
was released in 10.12.0

So this image is not correct for 10.11

Maybe something was accidentally backported to 10;11 that caused this image to be referenced? And so that accidental backport should be reverted.

@mmattel
Copy link
Copy Markdown
Contributor Author

mmattel commented Jun 15, 2023

Maybe something was accidentally backported

I did not find a reference to this image in any page of 10.11
With the upcoming 10.13 this release is no longer supported or visible in docs. Is it really worth to search for the cause?

@mmattel
Copy link
Copy Markdown
Contributor Author

mmattel commented Jun 16, 2023

I did some investigation:
git log --follow --diff-filter=A -- **concious-persistent-major-versions.png
--> commit 7d67bd2981ad162fa80621a7783fa45afc1af2d2

Then searching for this commit in GH, I get PR #600 - which is master only and has no backports...
Furthermore, checking page content, the differences between master and 10.11 are correct.

I would like to merge therefore.

@mmattel mmattel merged commit 835f9dd into 10.11 Jun 16, 2023
@delete-merged-branch delete-merged-branch Bot deleted the fix_missing_image branch June 16, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants