chore(deps-dev): bump @asciidoctor/core from 3.0.4 to 4.0.0#1028
chore(deps-dev): bump @asciidoctor/core from 3.0.4 to 4.0.0#1028dependabot[bot] wants to merge 1 commit into
Conversation
DeepDiver1975
left a comment
There was a problem hiding this comment.
@asciidoctor/core 3.0.4 → 4.0.0 (JS package) — MAJOR bump review
This bumps @asciidoctor/core one major version. It powers the docs-ui build/preview rendering.
package.json+package-lock.jsonchange only; lockfile also drops the bundled@asciidoctor/opal-runtime/glob/unxhrsubtree and raises the engine requirement tonode >=20(was>=16). ✅ manifest/lockfile consistent.- CI status:
buildjob FAILS. ❌
The build fails with a confirmed breaking change:
TypeError: require(...) is not a function
at Object.<anonymous> (tasks/build-preview.js:3:49)
tasks/build-preview.js line 3 does const Asciidoctor = require('@asciidoctor/core')() — i.e. it calls the module export as a factory function. Asciidoctor.js 4.0 changed the module's export shape so the package is no longer directly callable that way, so the immediate invocation throws. This is a genuine v3→v4 API break that the PR does not adapt the consuming code to. The build/preview task must be updated (e.g. to the v4 way of obtaining an Asciidoctor instance) before this dependency bump can land.
Verdict: changes requested — do not merge as-is. CI is red due to a real breaking change in the toolchain API; merging would break the docs-ui build/preview. The accompanying source code needs to be migrated to the Asciidoctor.js 4.x API. Changelog: n/a (no changelog convention in this repo).
🤖 Generated with Claude Code
Bumps [@asciidoctor/core](https://github.com/asciidoctor/asciidoctor.js) from 3.0.4 to 4.0.0. - [Release notes](https://github.com/asciidoctor/asciidoctor.js/releases) - [Changelog](https://github.com/asciidoctor/asciidoctor.js/blob/main/CHANGELOG.adoc) - [Commits](asciidoctor/asciidoctor.js@v3.0.4...v4.0.0) --- updated-dependencies: - dependency-name: "@asciidoctor/core" dependency-version: 4.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
854c9bc to
4592841
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
Re-reviewed at head 4592841 (new commits since last sweep).
What changed: the new commit is a lockfile/manifest refresh only — package.json + package-lock.json, bumping @asciidoctor/core ^3.0.4 → ^4.0.0 (also bumps the required Node engine to >=20 and drops opal-runtime/glob/unxhr). No application code was changed — in particular tasks/build-preview.js was not migrated.
CI: still RED. The build job fails with exactly the same error as last sweep:
TypeError: require(...) is not a function
at Object.<anonymous> (/.../tasks/build-preview.js:3:49)
Assessment — changes requested. asciidoctor.js v4 dropped the default callable-factory export, so require('@asciidoctor/core')() no longer works. This is a breaking API change the bump must accompany: build-preview.js needs to switch to the v4 named export (e.g. const { Asciidoctor } = require('@asciidoctor/core'); const asciidoctor = Asciidoctor(); — confirm against the v4 README) before the version bump can land. As-is the build is broken.
No changelog convention in this repo, so nothing required there. Not merging while CI is red and the API migration is missing.
🤖 Generated with Claude Code
Bumps @asciidoctor/core from 3.0.4 to 4.0.0.
Release notes
Sourced from @asciidoctor/core's releases.
... (truncated)
Changelog
Sourced from @asciidoctor/core's changelog.
... (truncated)
Commits
c73c6974.0.0b918740fix(extensions): preserve directly-registered extensions across registry reuse1b7efdcdocs: document registry reuse behaviour and add tests0ac262bdocs(extensions): add@overloadsignatures to IncludeProcessorDsl#handlesb02ce92feat(cli): warn when extension does not export a register function81a909atest: add CJS extension support test and document ESM/CJS formatsb1bba08feat: add --extension CLI option and clarify --require contractd068c524.0.0-alpha.6505c48adocs(changelog): move admonition caption fix to unreleased sectione8e93bafix(core): store caption text in textlabel for delimited admonition blocksMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@asciidoctor/coresince your current version.