Skip to content

Conversation

@mmattel
Copy link
Collaborator

@mmattel mmattel commented Jan 14, 2025

This PR switches from yarn to pure npm.

  • Update .drone.star
  • Remove yarn.lock
  • Update package.json and lint-js.js
    Switching from gulp-eslint --> gulp-eslint-new due to dependency incompatibilities
  • Update README
  • Added the depcheck package
    Removed all packages that were nowhere used (tested individually via remove/install/build)
    Added packages to js where missing
    npx depcheck
    npx depcheck --specials eslint
    Note, not all can be removed, but we see tips where fixes are needed...

Note that yarn resolutions in package.json are overrides in npm.
The following can be added if necessary. It removes glob warnings in case of debugging asciidoc. glob will be updated on the asciidoc side whenever they are ready...

  "overrides": {
    "glob-parent": "^5.1.2"
  },

Note that now with using npm, preview using a demo Antora build is working again 😃

With this PR, all doc repos are now using npm consistently and yarn is gone.

@mmattel mmattel added dependencies Pull requests that update a dependency file deployment labels Jan 14, 2025
@mmattel mmattel requested a review from phil-davis January 14, 2025 11:48
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmattel mmattel force-pushed the move_from_yarn_to_npm branch from b2d3d46 to 880607b Compare January 15, 2025 08:46
@mmattel mmattel merged commit fe579dd into master Jan 15, 2025
1 check passed
@mmattel mmattel deleted the move_from_yarn_to_npm branch January 15, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants