Realign UI and add a managable owncloud overlay#868
Merged
Conversation
phil-davis
approved these changes
May 1, 2025
Contributor
phil-davis
left a comment
There was a problem hiding this comment.
I don't see any issue, but I'm not reviewing all that JS and CSS in detail!
Co-authored-by: Phil Davis <phil@jankaritech.com>
Contributor
Author
Thanks finding the comment typos 😅 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #864 (Update navigation, related files and some css)
This is a major change for the docs-ui. Though the outcome looks, beside intended changes, the same as it was before, stuff under the hood was changed heavily.
This includes css, handlebars (hbs in partials), js.
Note that we already had additional stuff for our UI such as own js or special css files.
Note that we still are ahead in many package versions that are used by the UI, which is very good.
This makes it much easier to update the UI whith changes in the default and to check if and where we need adaptions on our side if used. Or we want to do additions.
When doing a file comparison of the src/ folder compared to the Antora default UI, the majority of the files are now contentwise identical again, except where this was not possible due to eslint complains (we have an updated version that is more precise).
With this change, it is now much easier to do fixes, understand changes required for our overlay etc.
I have tested this intensively including full doc builds using local search and different screensizes.
Many thanks to @mzner and @LukasHirt for their support!