Skip to content

Realign UI and add a managable owncloud overlay#868

Merged
mmattel merged 2 commits intomasterfrom
update_more_css
May 2, 2025
Merged

Realign UI and add a managable owncloud overlay#868
mmattel merged 2 commits intomasterfrom
update_more_css

Conversation

@mmattel
Copy link
Copy Markdown
Contributor

@mmattel mmattel commented Apr 30, 2025

Continues #864 (Update navigation, related files and some css)

This is a major change for the docs-ui. Though the outcome looks, beside intended changes, the same as it was before, stuff under the hood was changed heavily.

  1. Realign to the Antora default UI in the src/ folder for the basic stuff (as of ~ 2025.04.18).
    This includes css, handlebars (hbs in partials), js.
    Note that we already had additional stuff for our UI such as own js or special css files.
    Note that we still are ahead in many package versions that are used by the UI, which is very good.
  2. Add an overlay with commented changes that are specific to ownCloud.
    This makes it much easier to update the UI whith changes in the default and to check if and where we need adaptions on our side if used. Or we want to do additions.
  3. Removed orphaned files that have not been used at all.
  4. Do some fixes that:
    • have been dragged along for a long time and nobody took care such as render issues.
    • have not been implemented but should have been made, mostly css, but also hbs and js.
    • has been implemented incomplete in hbs. I commented it out so we can finalize if necessary.

When doing a file comparison of the src/ folder compared to the Antora default UI, the majority of the files are now contentwise identical again, except where this was not possible due to eslint complains (we have an updated version that is more precise).

With this change, it is now much easier to do fixes, understand changes required for our overlay etc.

I have tested this intensively including full doc builds using local search and different screensizes.

Many thanks to @mzner and @LukasHirt for their support!

Copy link
Copy Markdown
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue, but I'm not reviewing all that JS and CSS in detail!

Comment thread src/css/owncloud.css Outdated
Comment thread src/css/owncloud.css Outdated
Co-authored-by: Phil Davis <phil@jankaritech.com>
@mmattel
Copy link
Copy Markdown
Contributor Author

mmattel commented May 2, 2025

I don't see any issue, but I'm not reviewing all that JS and CSS in detail!

Thanks finding the comment typos 😅 👍

@mmattel mmattel merged commit 00aa4ff into master May 2, 2025
1 check passed
@mmattel mmattel deleted the update_more_css branch May 2, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants