Update gulp #894
Merged
Update gulp #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return promises from build and pack. This allows us to use async/await in the gulpfile.js.
Build fails in case the font directory is missing. Add a .keep file to the font directory to prevent the build from failing.
Check whether the destination directory exists in build task. If it does not, create it to prevent the task from failing.
This replaces merge-stream with ordered-read-streams. In gulp 5, merge-stream is no longer officially supported. The ordered-read-streams is a drop-in replacement for merge-stream and is maintained by the gulp team. For more context, check the following issue: gulpjs/gulp#2802 (comment)
Fix the error in the format task by awaiting the prettierEslint promise. To test the fix, run the format using npx gulp format.
LukasHirt
force-pushed
the
update_gulp
branch
from
1ef7bd9 to
570eb12
Compare
LukasHirt
approved these changes
Oct 10, 2025
Collaborator
Author
|
I tested the outcome with a build that takes the generated zip from local and not from minio --> works well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to update gulp from v4.0.2 to v5.0.1.
If possible, the update of
gulp-zipfrom v5.1.0 to v6.1.0 will be included.npm run previewdoes no longer reportsanonymousouputs.Adding callbacks as required by gulp and creating proper tasks/series fixed this.
Did you forget to signal async completiondoes not work because.pipe(gulp.dest(dest))in build returns a promise but not the required files. Using gulp v4 without the callback finishes the build process and creates the files. Also see .on('end',callback) for an idea how to solve this.gulp-zipv6.1.0 inpack.jserrors withzip is not a function. This can be possibly caused by the missing output of the build process:If the input to the zip function is not a valid vinyl file stream, the zip method will not be available, leading to the "zip is not a function" error. In case of a missing file stream, this should be covered by a correct error message. Note that upgrading gulp-zip in package.json was removed and needs to be added when the build process using gulp v5 has been fixed.Currently on draft to add changes