Code needs updating due to core icewind/streams 0.7.2

[phil-davis]

core PR owncloud/core#37249 bumped icewind/streams from 0.7.1 to 0.7.2 in /apps/files_external/3rdparty

Last night the unit tests failed: https://drone.owncloud.com/owncloud/encryption/1263/4/4

There was 1 error:

1) OCA\Encryption\Tests\Command\FixEncryptedVersionTest::testEncryptedVersionIsNotZero
Declaration of OC\Files\Stream\Encryption::loadContext($name) should be compatible with Icewind\Streams\Wrapper::loadContext($name = NULL)

/var/www/owncloud/server/lib/private/Files/Stream/Encryption.php:513
/var/www/owncloud/server/lib/private/Files/Storage/Wrapper/Encryption.php:478
/var/www/owncloud/server/lib/private/Files/Storage/Wrapper/Checksum.php:59
/var/www/owncloud/server/lib/private/Files/Storage/Wrapper/Wrapper.php:296
/var/www/owncloud/server/lib/private/Files/View.php:1220
/var/www/owncloud/server/lib/private/Files/View.php:1066
/var/www/owncloud/server/lib/private/Files/Node/File.php:111
/var/www/owncloud/server/lib/private/legacy/util.php:422
/var/www/owncloud/server/lib/private/legacy/util.php:392
/var/www/owncloud/server/lib/private/User/Session.php:448
/var/www/owncloud/server/lib/private/User/Session.php:532
/var/www/owncloud/server/lib/private/User/Session.php:333
/var/www/owncloud/server/apps/encryption/tests/unit/Command/FixEncryptedVersionTest.php:107

--

There were 2 failures:

1) OCA\Encryption\Tests\Command\FixEncryptedVersionTest::testEncryptedVersionLessThanOriginalValue
Failed asserting that 'Verifying the content of file /test_enc_version_affected_user1/files/foo.txt\n
The file /test_enc_version_affected_user1/files/foo.txt is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/hello.txt\n
Attempting to fix the path: /test_enc_version_affected_user1/files/hello.txt\n
Decrement the encrypted version to 1\n
Increment the encrypted version to 3\n
Increment the encrypted version to 4\n
Increment the encrypted version to 5\n
The file /test_enc_version_affected_user1/files/hello.txt is: OK\n
Fixed the file: /test_enc_version_affected_user1/files/hello.txt with version 5\n
Verifying the content of file /test_enc_version_affected_user1/files/ownCloud Manual.pdf\n
The file /test_enc_version_affected_user1/files/ownCloud Manual.pdf is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/world.txt\n
Attempting to fix the path: /test_enc_version_affected_user1/files/world.txt\n
Increment the encrypted version to 2\n
Increment the encrypted version to 3\n
Increment the encrypted version to 4\n
The file /test_enc_version_affected_user1/files/world.txt is: OK\n
Fixed the file: /test_enc_version_affected_user1/files/world.txt with version 4\n
' contains "Verifying the content of file /test_enc_version_affected_user1/files/hello.txt
Attempting to fix the path: /test_enc_version_affected_user1/files/hello.txt
Decrement the encrypted version to 1
Increment the encrypted version to 3
Increment the encrypted version to 4
Increment the encrypted version to 5
Increment the encrypted version to 6
The file /test_enc_version_affected_user1/files/hello.txt is: OK
Fixed the file: /test_enc_version_affected_user1/files/hello.txt with version 6".

/var/www/owncloud/server/apps/encryption/tests/unit/Command/FixEncryptedVersionTest.php:203

2) OCA\Encryption\Tests\Command\FixEncryptedVersionTest::testEncryptedVersionGreaterThanOriginalValue
Failed asserting that 'Verifying the content of file /test_enc_version_affected_user1/files/foo.txt\n
The file /test_enc_version_affected_user1/files/foo.txt is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/hello.txt\n
Attempting to fix the path: /test_enc_version_affected_user1/files/hello.txt\n
Decrement the encrypted version to 14\n
Decrement the encrypted version to 13\n
Decrement the encrypted version to 12\n
Decrement the encrypted version to 11\n
Decrement the encrypted version to 10\n
Decrement the encrypted version to 9\n
Decrement the encrypted version to 8\n
The file /test_enc_version_affected_user1/files/hello.txt is: OK\n
Fixed the file: /test_enc_version_affected_user1/files/hello.txt with version 8\n
Verifying the content of file /test_enc_version_affected_user1/files/ownCloud Manual.pdf\n
The file /test_enc_version_affected_user1/files/ownCloud Manual.pdf is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/world.txt\n
Attempting to fix the path: /test_enc_version_affected_user1/files/world.txt\n
Decrement the encrypted version to 14\n
Decrement the encrypted version to 13\n
Decrement the encrypted version to 12\n
Decrement the encrypted version to 11\n
Decrement the encrypted version to 10\n
Decrement the encrypted version to 9\n
Decrement the encrypted version to 8\n
The file /test_enc_version_affected_user1/files/world.txt is: OK\n
Fixed the file: /test_enc_version_affected_user1/files/world.txt with version 8\n
' contains "Verifying the content of file /test_enc_version_affected_user1/files/hello.txt
Attempting to fix the path: /test_enc_version_affected_user1/files/hello.txt
Decrement the encrypted version to 14
Decrement the encrypted version to 13
Decrement the encrypted version to 12
Decrement the encrypted version to 11
Decrement the encrypted version to 10
Decrement the encrypted version to 9
The file /test_enc_version_affected_user1/files/hello.txt is: OK
Fixed the file: /test_enc_version_affected_user1/files/hello.txt with version 9".

/var/www/owncloud/server/apps/encryption/tests/unit/Command/FixEncryptedVersionTest.php:276

ERRORS!
Tests: 251, Assertions: 721, Errors: 1, Failures: 2.

Likely we will need to bump core min-version to 10.5, if the needed changes rely on the things in icewind/streams 0.7.2

[phil-davis]

owncloud/core#37376 adjusts core so that the methods used by encryption have the updated method signatures.

[phil-davis]

Note: the changes were all in core. There was no change to encryption app code, and no change to the "interface" between encryption app and core. So no special release or core min-version is needed.