Skip to content

Add CI tests to drone#257

Merged
phil-davis merged 1 commit intomasterfrom
add-drone
Nov 15, 2018
Merged

Add CI tests to drone#257
phil-davis merged 1 commit intomasterfrom
add-drone

Conversation

@dpakach
Copy link
Copy Markdown
Contributor

@dpakach dpakach commented Nov 5, 2018

Add drone.yml file and tests to drone
related to #242

@individual-it
Copy link
Copy Markdown
Member

@ownclouders rebase

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@ac0556b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #257   +/-   ##
=========================================
  Coverage          ?   67.27%           
  Complexity        ?       25           
=========================================
  Files             ?        4           
  Lines             ?      110           
  Branches          ?        0           
=========================================
  Hits              ?       74           
  Misses            ?       36           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac0556b...0a7eb43. Read the comment docs.

@phil-davis
Copy link
Copy Markdown
Contributor

https://travis-ci.org/owncloud/files_texteditor/jobs/454907915

$ sh -c "if [ '$TC' = 'other' ]; then bash apps/$APP/tests/travis/start_php_unit_tests.sh; fi"
Running PHP unit tests
Could not read "phpunit.xml".
The command "sh -c "if [ '$TC' = 'other' ]; then bash apps/$APP/tests/travis/start_php_unit_tests.sh; fi"" exited with 1.

Moving stuff around broke the Travis script.
The easy way to fix that here is to remove the PHPunit jobs from the Travis YML! (since we are going to delete the whole of the Travis YML in the next PR anyway)
@dpakach

@phil-davis
Copy link
Copy Markdown
Contributor

For drone, it will need the new QA tarball tonight. That will have the FilesPageCRUD methods that were added to core today.

@phil-davis phil-davis dismissed individual-it’s stale review November 14, 2018 10:51

changes have been addressed

@dpakach dpakach force-pushed the add-drone branch 3 times, most recently from 9d13057 to fb128ce Compare November 15, 2018 07:37
@phil-davis phil-davis dismissed individual-it’s stale review November 15, 2018 10:51

review comments have been addressed

Copy link
Copy Markdown
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@phil-davis phil-davis merged commit 93f27a3 into master Nov 15, 2018
@phil-davis phil-davis deleted the add-drone branch November 15, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants