Add endpoints for managing group membership

[rhafer]

• POST /groups/{id}/members/$ref (for adding a single member)
• DELETE graph/v1.0/groups/{id}/members/{id}/$ref (for deleting a single member)
• PATCH graph/v1.0/groups/{group-id} (for adding multiple members)

[rhafer]

• PATCH graph/v1.0/groups/{group-id} (for adding multiple members)

I am having some troube with adding the definition for being able to add multiple group members at once (using the above URL). According to the MS Docs multiple members can be added with PATCH to the above URL and a body containing something like this:

{
  "members@odata.bind": [
    "https://graph.microsoft.com/v1.0/directoryObjects/{id}",
    "https://graph.microsoft.com/v1.0/directoryObjects/{id}",
    "https://graph.microsoft.com/v1.0/directoryObjects/{id}"
    ]
}

We however already have PATCH operation defined for that URL using a different kind of body (basically for updating other group related attributes.

@micbar Any hints on how to solve this? (BTW, this shouldn't stop of from merging this PR. We can work it out later)

[micbar]

shouldn't we be able to create a key "members@odata.bind" which has a collection of directory objects as a value?

[rhafer]

shouldn't we be able to create a key "members@odata.bind"

@micbar hm, true. That should work. For some reason I thought the body for the PATCH on /groups/{id} required some additional attributes.Please review once more.

I still think the API for managing group memberships as defined in ms graph is not exactly nice. I am trying to follow it anyway here.

which has a collection of directory objects as a value?

Not really directory objects, but strings/uris referencing directory objects.

[refs]

shouldn't we be able to create a key "members@odata.bind" which has a collection of directory objects as a value?

@rhafer something like: https://swagger.io/docs/specification/data-models/data-types/#array

Also, mind this restriction by the msgraph spec:

Note that up to 20 members can be added in a single request

The key would, obviously, be located in the PATCH request body

[rhafer]

shouldn't we be able to create a key "members@odata.bind" which has a collection of directory objects as a value?

@rhafer something like: https://swagger.io/docs/specification/data-models/data-types/#array

Yeah that's what I did. :-)

Also, mind this restriction by the msgraph spec:

Note that up to 20 members can be added in a single request

The key would, obviously, be located in the PATCH request body

Yeah. Though that limit is not something I can express in this SPEC, is it? We might think about adding such a limit to the actual graph API implementation at some point though.

[refs]

yes it can be done within the spec: https://swagger.io/docs/specification/2-0/describing-parameters/

Additionally, you can:

use minItems and maxItems to control the size of the array,
enforce uniqueItems,

- in: query
  name: color
  required: false
  type: array
  minItems: 1
  maxItems: 5
  uniqueItems: true
  items:
    type: string
    enum: [black, white, gray, red, pink, orange, yellow, green, blue, purple, brown]

[refs]

@rhafer oh sorry, those docs are for v2. For v3: https://swagger.io/docs/specification/data-models/data-types/

[rhafer]

Ok, thanks. I've added those limits to the spec. It doesn't seem to have any effect on the generated go code for the client. But the limit itself needs to be implemented server side anyway.