Skip to content

fix session password#129

Merged
DeepDiver1975 merged 1 commit intomasterfrom
fix-session-password
Apr 19, 2018
Merged

fix session password#129
DeepDiver1975 merged 1 commit intomasterfrom
fix-session-password

Conversation

@butonic
Copy link
Copy Markdown
Contributor

@butonic butonic commented Apr 18, 2018

Found this while working on kerberos. Password should be null instead of '' IIUC that null triggers \OC\Authentication\Exceptions\PasswordlessTokenException to make sessions without a password work properly. No idea if ther is magic in core that converts '' to null ... oracle certainly has that magic ... so no idea how this affects the overall auth with oauth2.

  • Also needs PHPDoc update in core

@butonic butonic requested a review from DeepDiver1975 April 18, 2018 20:15
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2018

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #129   +/-   ##
=========================================
  Coverage     82.12%   82.12%           
  Complexity      199      199           
=========================================
  Files            21       21           
  Lines           705      705           
=========================================
  Hits            579      579           
  Misses          126      126
Impacted Files Coverage Δ Complexity Δ
lib/AuthModule.php 88.88% <100%> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487e277...a18835b. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 9e56b1c into master Apr 19, 2018
@DeepDiver1975 DeepDiver1975 deleted the fix-session-password branch April 19, 2018 07:20
@patrickjahns patrickjahns modified the milestones: development, 0.2.3 Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants