Skip to content

Add support for implicit grant#166

Merged
PVince81 merged 2 commits intomasterfrom
feature/implicit-grant
Oct 17, 2018
Merged

Add support for implicit grant#166
PVince81 merged 2 commits intomasterfrom
feature/implicit-grant

Conversation

@DeepDiver1975
Copy link
Copy Markdown
Member

@DeepDiver1975 DeepDiver1975 commented Oct 11, 2018

Fixes #165

Test Steps

  1. add a new client using the occ command
 ./occ oauth2:add-client test clientid-1234567890-1234567890-1234567890 secret-secret-secret-secret-secret http://localhost:9999
  1. open browser
    http://own.cloud.local/index.php/apps/oauth2/authorize?response_type=token&client_id=clientid-1234567890-1234567890-1234567890&redirect_uri=http://localhost:9999

  2. See authorization dialog - click button 'Authorize'

  3. See login dialog - login

  4. See redirect to url http://localhost:9999/?access_token=BBtaHzdCpXoRnN912G7hCPVcSHLSpKZbVF5tuwaLgxajj3mbpik7m2MHJOty1Vxk&expires_in=3600

  5. this access_token can now be used to call e.g.

curl -v http://own.cloud.local/index.php/apps/oauth2/api/v1/arer BBtaHzdCpXoRnN912G7hCPVcSHLSpKZbVF5tuwaLgxajj3mbpik7m2MHJOty1Vxk'

@DeepDiver1975 DeepDiver1975 self-assigned this Oct 11, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2018

Codecov Report

Merging #166 into master will decrease coverage by 2.42%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
- Coverage      82.2%   79.77%   -2.43%     
- Complexity      200      204       +4     
============================================
  Files            21       21              
  Lines           708      727      +19     
============================================
- Hits            582      580       -2     
- Misses          126      147      +21
Impacted Files Coverage Δ Complexity Δ
lib/AuthModule.php 88.88% <100%> (ø) 8 <0> (ø) ⬇️
lib/Controller/PageController.php 48.14% <31.25%> (-7.89%) 38 <0> (+4)
lib/Db/Client.php 84.61% <0%> (-15.39%) 4% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f4e6b...865f623. Read the comment docs.

Copy link
Copy Markdown
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and seems to match what I read in https://alexbilbie.com/guide-to-oauth-2-grants/ 👍

@DeepDiver1975 can you add the test scenario that describes how to manually test this ?

@PVince81
Copy link
Copy Markdown
Contributor

restarted CI for our favorite database...

@DeepDiver1975
Copy link
Copy Markdown
Member Author

Oracle in travis is broken. There is another pr to move to drone

@karakayasemi
Copy link
Copy Markdown

karakayasemi commented Oct 17, 2018

@DeepDiver1975 I got the same error for oracle in the following PR. Fixed it by updating ubuntu repos. https://github.com/owncloud/brute_force_protection/pull/40/files#diff-354f30a63fb0907d4ad57269548329e3R24

@PVince81 PVince81 merged commit aaa6ee6 into master Oct 17, 2018
@PVince81 PVince81 deleted the feature/implicit-grant branch October 17, 2018 12:53
@PVince81 PVince81 mentioned this pull request Nov 29, 2018
31 tasks
@PVince81 PVince81 added this to the QA milestone Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants