Conversation
71b9b8c to
f99e2dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
============================================
- Coverage 82.2% 79.77% -2.43%
- Complexity 200 204 +4
============================================
Files 21 21
Lines 708 727 +19
============================================
- Hits 582 580 -2
- Misses 126 147 +21
Continue to review full report at Codecov.
|
PVince81
left a comment
There was a problem hiding this comment.
Code looks good and seems to match what I read in https://alexbilbie.com/guide-to-oauth-2-grants/ 👍
@DeepDiver1975 can you add the test scenario that describes how to manually test this ?
|
restarted CI for our favorite database... |
|
Oracle in travis is broken. There is another pr to move to drone |
|
@DeepDiver1975 I got the same error for oracle in the following PR. Fixed it by updating ubuntu repos. https://github.com/owncloud/brute_force_protection/pull/40/files#diff-354f30a63fb0907d4ad57269548329e3R24 |
Fixes #165
Test Steps
open browser
http://own.cloud.local/index.php/apps/oauth2/authorize?response_type=token&client_id=clientid-1234567890-1234567890-1234567890&redirect_uri=http://localhost:9999
See authorization dialog - click button 'Authorize'
See login dialog - login
See redirect to url http://localhost:9999/?access_token=BBtaHzdCpXoRnN912G7hCPVcSHLSpKZbVF5tuwaLgxajj3mbpik7m2MHJOty1Vxk&expires_in=3600
this access_token can now be used to call e.g.
curl -v http://own.cloud.local/index.php/apps/oauth2/api/v1/arer BBtaHzdCpXoRnN912G7hCPVcSHLSpKZbVF5tuwaLgxajj3mbpik7m2MHJOty1Vxk'