Skip to content

feat: oc11#368

Merged
DeepDiver1975 merged 3 commits intomasterfrom
feat/oc11
Mar 6, 2026
Merged

feat: oc11#368
DeepDiver1975 merged 3 commits intomasterfrom
feat/oc11

Conversation

@DeepDiver1975
Copy link
Member

No description provided.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the acceptance test CI so that it does not run the acceptance tests with the "latest" core release. They only run with the daily-master-qa core tarball.
The changed DBAL code is not compatible to run along with ownCloud core 10.

@DeepDiver1975
Copy link
Member Author

I will change the code. This was not intended. We aim to have all apps compatible with 10 and 11.

@phil-davis
Copy link
Contributor

I will change the code. This was not intended. We aim to have all apps compatible with 10 and 11.

Note: this also happened with owncloud/configreport#213

Quite a few apps have had doctrine/dbal-related changes that probably mean they will not work with core 10.16.1

The doctrine/dbal major version bump has been done in core while still using PHP 7.4. Maybe a 10.17.0 core release could be done, with updated apps that have current doctrine/dbal code?

Otherwise there will be various "if" statements to do things differently depending which doctrine/dbal version is available. And we should then run the PHP unit tests twice - with core 10.16.1 and core master.

Or?

@DeepDiver1975
Copy link
Member Author

specifically in this case the breaking change was to use Mapper::executeStatement which was recently introduced and is not part of oc10 - only slightly related to the dbal changes

@DeepDiver1975
Copy link
Member Author

with config report it is a bit different due to the changes related to MySqlPlatform vs MySQLPlatform - we need to make sure configreport has min version oc11

@DeepDiver1975 DeepDiver1975 merged commit 48c95e2 into master Mar 6, 2026
9 checks passed
@DeepDiver1975 DeepDiver1975 deleted the feat/oc11 branch March 6, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants