Skip to content

[tests-only][full-ci] test: adjust PHP code to support v8.4#11459

Merged
LukasHirt merged 1 commit intomasterfrom
test/support-php-8.4
Jun 26, 2025
Merged

[tests-only][full-ci] test: adjust PHP code to support v8.4#11459
LukasHirt merged 1 commit intomasterfrom
test/support-php-8.4

Conversation

@LukasHirt
Copy link
Contributor

@LukasHirt LukasHirt commented Jun 24, 2025

JIRA: OCISDEV-80

Description

The implicite nullable type has been deprecated. This fixes it by explicitely typing every nullable type. PHP is also bumped in composer and drone to run tests with v8.4.

Motivation and Context

Tests can be run with PHP v8.4.

How Has This Been Tested?

  • test environment: macOS 15.5
  • test case 1: run acceptance tests with PHP v8.4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@LukasHirt LukasHirt self-assigned this Jun 24, 2025
@LukasHirt LukasHirt force-pushed the test/support-php-8.4 branch 2 times, most recently from 3a4937a to 31224b0 Compare June 25, 2025 07:43
@LukasHirt LukasHirt requested a review from saw-jan June 25, 2025 07:44
@LukasHirt
Copy link
Contributor Author

@deyankiteworks @saw-jan the style test step now fails because the php-cs-fixer does not yet fully support PHP v8.4. I tested it locally with PHP_CS_FIXER_IGNORE_ENV=true and it passed fine. Which direction do you want to go? Run the step with the env var? Or downgrade the PHP image in the CI to v8.3 which is supported by the php-cs-fixer? In both scenarios we can of course keep the deprecation fixes to support running tests with v8.4 locally at least.

@saw-jan
Copy link
Member

saw-jan commented Jun 25, 2025

@deyankiteworks @saw-jan the style test step now fails because the php-cs-fixer does not yet fully support PHP v8.4. I tested it locally with PHP_CS_FIXER_IGNORE_ENV=true and it passed fine. Which direction do you want to go? Run the step with the env var? Or downgrade the PHP image in the CI to v8.3 which is supported by the php-cs-fixer? In both scenarios we can of course keep the deprecation fixes to support running tests with v8.4 locally at least.

We are moving forward, so I would say let's go with PHP_CS_FIXER_IGNORE_ENV=true. phpcsfixer will eventually support 8.4 (see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/milestone/173)

@LukasHirt LukasHirt force-pushed the test/support-php-8.4 branch from 31224b0 to f2d2bc6 Compare June 26, 2025 07:08
The implicite nullable type has been deprecated.
This fixes it by explicitely typing every nullable type.
PHP is also bumped in composer and drone to v8.4.
@LukasHirt LukasHirt force-pushed the test/support-php-8.4 branch from f2d2bc6 to b933f48 Compare June 26, 2025 07:10
@sonarqubecloud
Copy link

@LukasHirt LukasHirt enabled auto-merge June 26, 2025 07:47
@LukasHirt LukasHirt merged commit d780a50 into master Jun 26, 2025
4 checks passed
ownclouders pushed a commit that referenced this pull request Jun 26, 2025
[tests-only][full-ci] test: adjust PHP code to support v8.4
@github-actions github-actions bot deleted the test/support-php-8.4 branch October 15, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants