Skip to content

feat: [OCISDEV-531] add vault capabilities to the OCS capabilities endpoint#12283

Merged
2403905 merged 1 commit into
feat/OCISDEV-533-graphfrom
feat/OCISDEV-531
May 13, 2026
Merged

feat: [OCISDEV-531] add vault capabilities to the OCS capabilities endpoint#12283
2403905 merged 1 commit into
feat/OCISDEV-533-graphfrom
feat/OCISDEV-531

Conversation

@2403905
Copy link
Copy Markdown
Contributor

@2403905 2403905 commented May 6, 2026

Description

Added vault capabilities to the OCS capabilities endpoint

Added OCIS_ENABLE_VAULT_MODE / FRONTEND_ENABLE_VAULT_MODE config option to
the frontend service. When enabled, the OCS capabilities endpoint advertises
vault.enabled = true. Clients can request vault-specific capabilities via
/ocs/v2.php/cloud/capabilities?vault=true, which returns a response with
public sharing and federation sharing disabled.
The part of the Story feat/OCISDEV-533-graph

Related issue owncloud/reva#584

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905 2403905 force-pushed the feat/OCISDEV-533-graph branch 3 times, most recently from 3d5a280 to ba38ca0 Compare May 11, 2026 12:33
@2403905 2403905 force-pushed the feat/OCISDEV-531 branch from 84b2a70 to 15b9ed6 Compare May 11, 2026 13:43
@2403905 2403905 marked this pull request as ready for review May 11, 2026 13:48
@2403905 2403905 requested review from jvillafanez and kobergj May 11, 2026 19:11
@jvillafanez
Copy link
Copy Markdown
Member

I think we'll have to figure out how we can implement the capabilities properly.

Right now, with this PR, we have 3 different flags that must be enabled for the feature to work properly. The flags also belong to different services, so it might be difficult to find them unless all the related flags are documented together. As such, it's possible for the capability flag to be enabled while the rest of the flags are disabled, so you'd advertise a feature that is disabled.
In addition, it's questionable to have a flag just for advertisement. The flag doesn't affect the feature in any meaningful way.

I'm not sure if we have better options at the moment, but I think it's worthy to add it in the TODO list.

Comment on lines +7 to +9
PROXY_CREATE_VAULT_HOME: true
PROXY_ENABLE_VAULT_MODE: true
GRAPH_ENABLE_VAULT_MODE: true
FRONTEND_ENABLE_VAULT_MODE: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCIS_ENABLE_VAULT_MODE should be used instead since it's the preferred option

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@2403905 2403905 force-pushed the feat/OCISDEV-531 branch from 15b9ed6 to 70b5345 Compare May 12, 2026 09:23
Copy link
Copy Markdown
Member

@jvillafanez jvillafanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick change

@2403905 2403905 force-pushed the feat/OCISDEV-531 branch 2 times, most recently from e96468f to 8431e96 Compare May 12, 2026 11:48
@2403905
Copy link
Copy Markdown
Contributor Author

2403905 commented May 12, 2026

I think we'll have to figure out how we can implement the capabilities properly.

Right now, with this PR, we have 3 different flags that must be enabled for the feature to work properly. The flags also belong to different services, so it might be difficult to find them unless all the related flags are documented together. As such, it's possible for the capability flag to be enabled while the rest of the flags are disabled, so you'd advertise a feature that is disabled. In addition, it's questionable to have a flag just for advertisement. The flag doesn't affect the feature in any meaningful way.

I'm not sure if we have better options at the moment, but I think it's worthy to add it in the TODO list.

@jvillafanez All of 3 flags have a common one OCIS_ENABLE_VAULT_MODE. The readme will be provided in a feature branch feat/OCISDEV-533-graph

@2403905 2403905 requested a review from jvillafanez May 12, 2026 12:56
@2403905 2403905 force-pushed the feat/OCISDEV-531 branch from 8431e96 to b4266e7 Compare May 13, 2026 11:16
@2403905 2403905 merged commit b95df4d into feat/OCISDEV-533-graph May 13, 2026
107 of 109 checks passed
@2403905 2403905 deleted the feat/OCISDEV-531 branch May 13, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants