Skip to content

fix(proxy): [OCISDEV-845] skip space reconciliation on signed URL requests#12285

Merged
kobergj merged 2 commits intoowncloud:stable-8.0from
kobergj:feat/OCISDEV-845-fix-space-manager-signed-url
May 6, 2026
Merged

fix(proxy): [OCISDEV-845] skip space reconciliation on signed URL requests#12285
kobergj merged 2 commits intoowncloud:stable-8.0from
kobergj:feat/OCISDEV-845-fix-space-manager-signed-url

Conversation

@kobergj
Copy link
Copy Markdown
Contributor

@kobergj kobergj commented May 6, 2026

Summary

  • Fix space management middleware removing users from all project spaces on signed URL (download) requests
  • When no OIDC claims are in the request context (signed URL auth), the middleware now skips reconciliation entirely instead of interpreting absent claims as "user should have no access"
  • Resolves intermittent download failures and transient "space not found" errors in EOSC environments

Technical Details

getSpaceAssignments() now returns nil (not empty map) when oidc.FromContext(ctx) is nil, and ServeHTTP skips processing when assignments are nil. This distinguishes "no claims available" from "claims say no access".

Test plan

  • Deploy to EOSC test environment running claim-based space management
  • Verify file downloads from project spaces succeed consistently
  • Verify no more SpaceShared/SpaceUnshared oscillation in logs
  • Verify OIDC-authenticated requests still correctly reconcile space memberships

Fixes: https://kiteworks.atlassian.net/browse/OCISDEV-845

🤖 Generated with Claude Code

…uests

The space management middleware removed users from all project spaces
when processing signed URL requests because no OIDC claims are present
in that auth context. Return early when claims are nil to prevent the
oscillating add/remove cycle.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Julian Koberg <julian.koberg@kiteworks.com>
@update-docs
Copy link
Copy Markdown

update-docs Bot commented May 6, 2026

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Julian Koberg <julian.koberg@kiteworks.com>
@kobergj kobergj merged commit c9f2a39 into owncloud:stable-8.0 May 6, 2026
55 checks passed
@kobergj kobergj deleted the feat/OCISDEV-845-fix-space-manager-signed-url branch May 6, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants