Rebuild index#749
Merged
Merged
Conversation
butonic
suggested changes
Oct 23, 2020
|
|
||
| Tags: accounts | ||
|
|
||
| The index for the accounts service can now be rebuilt by running the cli command `./bin/ocis accounts rebuild`. It deletes all configured indices and rebuilds them from the documents found on storage. |
Contributor
There was a problem hiding this comment.
and you added a ListAccounts & ListGroups call
butonic
approved these changes
Oct 23, 2020
Contributor
butonic
left a comment
butonic
left a comment
There was a problem hiding this comment.
the only real naming issue is the RebuildIndex ... other than that I'm good
Contributor
Author
|
@refs we should take the time and write an integration test, at least with the disk implementation. |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI command for rebuilding the index. Can be called from accounts cli with
rebuildcommand.