[WIP] Added function to get share info #69

PVince81 · 2015-02-08T17:53:46Z

Follow up of #63

Remaining tasks:

Add python docs for the ShareInfo methods (I can help if needed as I might be more familiar with what they represent)
remove PublicShare and UserShare classes if possible and replace with ShareInfo. But I suspect that share_with_link doesn't get a full ShareInfo instance, is that correct ? (we can also address this separately as it's more tricky)

PVince81 · 2015-02-08T18:08:11Z

verify that "path" is the source path, not the target path (run as recipient and owner)

SergioBertolinSG · 2015-12-16T16:59:43Z

Failures I've got while running tests of this branch http://paste.debian.net/348550/

SergioBertolinSG · 2015-12-17T10:03:06Z

OK the 403 errors where returned because share user in target server wasn't created.

Two problems here:

share user should be created and deleted during the test in my opinion.
403 answer is not well documented. Official doc names it as 403 - public upload was disabled by the admin. Which is not the case.

SergioBertolinSG · 2015-12-17T10:03:53Z

Now failing owncloud/test/test.py::TestFileAccess::test_rename_unicode

ConnectionError: ('Connection aborted.', error(61, 'Connection refused'))

SergioBertolinSG · 2015-12-17T10:49:19Z

Apart from the failing test 👍

PVince81 · 2015-12-17T11:06:00Z

Hmm, needs rebase due to conflicts

SergioBertolinSG · 2015-12-17T13:02:01Z

Rebased.

PVince81 · 2015-12-17T13:20:33Z

Github still says it has conflicts. Make sure you pulled/fetched master before rebasing.

SergioBertolinSG · 2015-12-17T13:24:23Z

Yes, last merge added a new one. Rebased again.

PVince81 · 2015-12-17T13:28:42Z

We might also want to change get_shares to return instances of ShareInfo and PublicShare, if possible. Might be complicated though. Maybe we can merge this first.
Also changing get_shares might break API consumers already using it... (smashbox, etc)

@SergioBertolinSG what do you think ?

SergioBertolinSG · 2015-12-17T14:01:06Z

I've searched smashbox and there is no use of the method get_shares there.

Yes I think it is better to return instances.

SergioBertolinSG · 2015-12-18T13:35:39Z

@PVince81 please review. I guess oc 7 fail with test_share_with_group can be addressed in an upcoming PR.

SergioBertolinSG · 2015-12-18T13:58:40Z

These smashbox tests will need some changes.

./lib/owncloud/test_sharePropagation.py
./lib/owncloud/test_sharePropagationGroups.py
./lib/owncloud/test_sharePropagationInside.py
./lib/owncloud/test_sharePropagationInsideGroups.py

Better to change them or make share_id a public field?

PVince81 · 2015-12-18T14:15:09Z

Yeah, make share id a public field. Could be useful in other cases.

PVince81 · 2015-12-18T14:15:33Z

owncloud/owncloud.py

+            return value
+        except:
+            return None
+
 class PublicShare():


should this extend ShareInfo ?

They can be removed (UserShare and PublicShare). Is that a bad option?

We can remove UserShare.

But we cannot remove PublicShare because it exists since v0.1, that would break existing API.
This, unless ShareInfo's API is compatible. Goal is to not break scripts that were using v0.1.

PVince81 · 2015-12-18T14:16:33Z

Code looks good otherwise 😄

SergioBertolinSG · 2015-12-21T11:23:48Z

@PVince81 please review.

PVince81 · 2015-12-21T11:27:00Z

owncloud/owncloud.py

-        return "UserShare(id=%i,path='%s',perms=%s)" % \
-               (self.share_id, self.share, self.perms)
-
-
 class GroupShare():


Remove GroupShare too ?

For some reason I don't see its usage on your branch, but I see it here https://github.com/owncloud/pyocclient/blob/master/owncloud/owncloud.py#L1212
You might need to rebase onto master to get this recently merged functionality

* Added internal function __get_shareinfo() - will be used repeatedly

…_int()

SergioBertolinSG · 2015-12-22T12:20:52Z

@PVince81 Tests passing.

PVince81 · 2015-12-22T12:41:42Z

Please check if smashbox can still run against this branch, if yes then good to go 👍

SergioBertolinSG · 2015-12-22T16:17:45Z

Smashbox sharing tests are working now.

PVince81 · 2015-12-22T16:27:26Z

👍

[WIP] Added function to get share info

PVince81 mentioned this pull request Feb 8, 2015

[WIP] get_share() to retrieve share information about known share (by id) #63

Closed

PVince81 mentioned this pull request Mar 12, 2015

Add more share API calls #7

Closed

PVince81 mentioned this pull request Aug 21, 2015

0.2 release plan #115

Closed

11 tasks

SergioBertolinSG force-pushed the shares-getshareinfo branch from ee38195 to d0ad2c3 Compare December 17, 2015 13:01

SergioBertolinSG force-pushed the shares-getshareinfo branch from d0ad2c3 to d84162d Compare December 17, 2015 13:23

PVince81 reviewed Dec 18, 2015
View reviewed changes

PVince81 reviewed Dec 21, 2015
View reviewed changes

SergioBertolinSG force-pushed the shares-getshareinfo branch from 066ba6b to 101ed37 Compare December 21, 2015 14:14

Soal added 6 commits December 22, 2015 13:05

get_share() to retrieve share information about known share (by id)

80c51aa

Cosmetic fix @ class ShareInfo

2743947

Added getters to ShareInfo class

84abc16

* Bug fix - return int instead of string

d1627ce

* Added internal function __get_shareinfo() - will be used repeatedly

Change returned type to int in few cases and add simple wrapper __get…

9f352cb

…_int()

Add some unittests for get_share()

e846ebe

Soal and others added 7 commits December 22, 2015 13:05

Remove unnecessary attributes and ShareInfo class methods.

f80b42e

Added docstrings for ShareInfo methods, fixed tests

0efe137

Added link to shareinfo class

888f1ea

Changed PublicShare and UserShare for ShareInfo

6c06113

get_share needed to return the element inside data

52c3661

share_id is public and PublicShare inherits from ShareInfo

b5079ef

Removed GroupShare and changed tests using it

8929bad

SergioBertolinSG force-pushed the shares-getshareinfo branch from 101ed37 to 8929bad Compare December 22, 2015 12:06

Making token public for compatibilty reasons

fcf70d8

PVince81 pushed a commit that referenced this pull request Dec 22, 2015

Merge pull request #69 from owncloud/shares-getshareinfo

9be686c

[WIP] Added function to get share info

PVince81 merged commit 9be686c into master Dec 22, 2015

PVince81 deleted the shares-getshareinfo branch December 22, 2015 16:27

[WIP] Added function to get share info #69

[WIP] Added function to get share info #69

Uh oh!

Conversation

PVince81 commented Feb 8, 2015

Uh oh!

PVince81 commented Feb 8, 2015

Uh oh!

SergioBertolinSG commented Dec 16, 2015

Uh oh!

SergioBertolinSG commented Dec 17, 2015

Uh oh!

SergioBertolinSG commented Dec 17, 2015

Uh oh!

SergioBertolinSG commented Dec 17, 2015

Uh oh!

PVince81 commented Dec 17, 2015

Uh oh!

SergioBertolinSG commented Dec 17, 2015

Uh oh!

PVince81 commented Dec 17, 2015

Uh oh!

SergioBertolinSG commented Dec 17, 2015

Uh oh!

PVince81 commented Dec 17, 2015

Uh oh!

SergioBertolinSG commented Dec 17, 2015

Uh oh!

SergioBertolinSG commented Dec 18, 2015

Uh oh!

SergioBertolinSG commented Dec 18, 2015

Uh oh!

PVince81 commented Dec 18, 2015

Uh oh!

PVince81 Dec 18, 2015

Choose a reason for hiding this comment

Uh oh!

SergioBertolinSG Dec 21, 2015

Choose a reason for hiding this comment

Uh oh!

PVince81 Dec 21, 2015

Choose a reason for hiding this comment

Uh oh!

PVince81 commented Dec 18, 2015

Uh oh!

SergioBertolinSG commented Dec 21, 2015

Uh oh!

PVince81 Dec 21, 2015

Choose a reason for hiding this comment

Uh oh!

SergioBertolinSG commented Dec 22, 2015

Uh oh!

PVince81 commented Dec 22, 2015

Uh oh!

SergioBertolinSG commented Dec 22, 2015

Uh oh!

PVince81 commented Dec 22, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants