fix(security): validate core-ref input before checkout#45
Closed
DeepDiver1975 wants to merge 1 commit intomainfrom
Closed
fix(security): validate core-ref input before checkout#45DeepDiver1975 wants to merge 1 commit intomainfrom
DeepDiver1975 wants to merge 1 commit intomainfrom
Conversation
Add an explicit validation step that rejects core-ref and core-ref-php74 values containing characters outside [a-zA-Z0-9._/=-], preventing a caller from pointing the checkout at an arbitrary or malicious ref that could execute hostile Makefile targets.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputs.core-refandinputs.core-ref-php74were passed directly toactions/checkout'sref:parameter with no validationowncloud/corecontaining a malicious Makefile that runs arbitrary code whenmakeis called in subsequent steps[a-zA-Z0-9._/=-]Security impact
MEDIUM — requires the attacker to also control a branch in
owncloud/core, limiting exploitability, but the ref is fully caller-controlled.Test plan
v10.14.0, branch names likemaster, SHAs) still pass validation🤖 Generated with Claude Code