pass access token ttl value to wopi client#364
Conversation
mrow4a
left a comment
There was a problem hiding this comment.
exactly how I would expect it to work. Great work! Unit tests not straightforward I belive?
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
===========================================
+ Coverage 6.16% 9.18% +3.02%
Complexity 307 307
===========================================
Files 14 14
Lines 1200 1197 -3
===========================================
+ Hits 74 110 +36
+ Misses 1126 1087 -39
Continue to review full report at Codecov.
|
|
There is no dependency injection in php classes. Also, touched classes have too many |
|
@phil-davis Could you help for merging this pull request? |
320d299 to
fab6323
Compare
…e actions when token about to expire
fab6323 to
f489f0b
Compare
Wopi protocol suggests returning access_token_ttl value to wopi client. In this way, wopi client can decide what to do when token about to expire.

For example, collabora warns user when 15 minutes before expire and shows below message to user:
If user still doesn't refresh the session, it warns again periodically in every 2 minutes.
Fixes owncloud/enterprise#4237