Drone issues after merging in: photo-addon extension #308
Description
@paul43210
@LukasHirt FYI
These issues arised after merging
CI was green in the PR, but checking drone after merging showed the following, finally does not build the image.
The warnings should be fixed, the errors MUST be fixed.
Linter
+ pnpm lintweb-extensions@ lint /drone/src
eslint '{packages,support}/**/.{js,ts,vue}' '.{ts,js}' --color
/drone/src/packages/web-app-draw-io/src/App.vue
34:5 warning Prop "applicationConfig" should be optional vue/no-required-prop-with-default
/drone/src/packages/web-app-photo-addon/src/components/PhotoContextMenu.vue
3:68 warning Attribute "ref" should go before ":style" vue/attributes-order
/drone/src/packages/web-app-photo-addon/src/components/PhotoGrid.vue
9:7 warning Attribute "tabindex" should go before "@keydown.enter" vue/attributes-order
10:7 warning Attribute "role" should go before "@keydown.enter" vue/attributes-order
11:7 warning Attribute ":aria-label" should go before "@keydown.enter" vue/attributes-order
/drone/src/packages/web-app-photo-addon/src/components/PhotoLightbox.vue
2:3 error Visible, non-interactive elements should not have an interactive handler vuejs-accessibility/no-static-element-interactions
14:5 error Elements with the "menu" interactive role must be focusable vuejs-accessibility/interactive-supports-focus
15:7 error @mouseOver, @mouseenter, or @hover must be accompanied by @focusin or @Focus for accessibility vuejs-accessibility/mouse-events-have-key-events
15:7 error @mouseout or @Mouseleave must be accompanied by @focusout or @blur for accessibility vuejs-accessibility/mouse-events-have-key-events
19:7 error @mouseOver, @mouseenter, or @hover must be accompanied by @focusin or @Focus for accessibility vuejs-accessibility/mouse-events-have-key-events
19:7 error @mouseout or @Mouseleave must be accompanied by @focusout or @blur for accessibility vuejs-accessibility/mouse-events-have-key-events
23:7 error @mouseOver, @mouseenter, or @hover must be accompanied by @focusin or @Focus for accessibility vuejs-accessibility/mouse-events-have-key-events
23:7 error @mouseout or @Mouseleave must be accompanied by @focusout or @blur for accessibility vuejs-accessibility/mouse-events-have-key-events
28:7 error @mouseOver, @mouseenter, or @hover must be accompanied by @focusin or @Focus for accessibility vuejs-accessibility/mouse-events-have-key-events
28:7 error @mouseout or @Mouseleave must be accompanied by @focusout or @blur for accessibility vuejs-accessibility/mouse-events-have-key-events
43:11 warning Attribute ":aria-label" should go before "@click.stop" vue/attributes-order
47:76 warning Attribute ":aria-label" should go before "@click" vue/attributes-order
65:7 error Visible, non-interactive elements with click handlers must have at least one keyboard listener vuejs-accessibility/click-events-have-key-events
65:7 error Visible, non-interactive elements should not have an interactive handler vuejs-accessibility/no-static-element-interactions
78:11 warning Attribute ":aria-label" should go before "@click.stop" vue/attributes-order
109:11 warning Attribute ":aria-label" should go before "@click.stop" vue/attributes-order
220:15 warning 'GeoCoordinates' is defined but never used @typescript-eslint/no-unused-vars
220:15 error 'GeoCoordinates' is defined but never used unused-imports/no-unused-imports
478:7 warning 'downloadUrl' is assigned a value but never used @typescript-eslint/no-unused-vars
679:1 warning Async function 'preloadNearbyImages' has no 'await' expression require-await
735:16 warning 'err' is defined but never used @typescript-eslint/no-unused-vars
793:24 warning 'event' is defined but never used @typescript-eslint/no-unused-vars
/drone/src/packages/web-app-photo-addon/src/components/PhotoMap.vue
23:56 warning 'nextTick' is defined but never used @typescript-eslint/no-unused-vars
23:56 error 'nextTick' is defined but never used unused-imports/no-unused-imports
26:15 warning 'GeoCoordinates' is defined but never used @typescript-eslint/no-unused-vars
26:15 error 'GeoCoordinates' is defined but never used unused-imports/no-unused-imports
98:7 warning 'CLUSTER_RADIUS_METERS' is assigned a value but never used @typescript-eslint/no-unused-vars
112:12 warning 'e' is defined but never used @typescript-eslint/no-unused-vars
126:12 warning 'e' is defined but never used @typescript-eslint/no-unused-vars
572:29 warning 'e' is defined but never used @typescript-eslint/no-unused-vars
/drone/src/packages/web-app-photo-addon/src/views/PhotosView.vue
6:5 warning Attribute "ref" should go before ":aria-label" vue/attributes-order
19:41 warning Attribute "id" should go before "class" vue/attributes-order
24:15 warning Attribute "class" should go before "@change" vue/attributes-order
25:15 warning Attribute ":aria-label" should go before "@change" vue/attributes-order
33:15 warning Attribute "class" should go before "@change" vue/attributes-order
34:15 warning Attribute ":aria-label" should go before "@change" vue/attributes-order
38:65 warning Attribute "class" should go before "@click" vue/attributes-order
38:83 warning Attribute ":title" should go before "@click" vue/attributes-order
61:36 warning Attribute "id" should go before "type" vue/attributes-order
61:58 warning Attribute "v-model" should go before "type" vue/attributes-order
87:38 warning Attribute "v-if" should go before "class" vue/attributes-order
93:34 warning Attribute "class" should go before "@click" vue/attributes-order
123:17 warning Attribute ":ref" should go before ":aria-label" vue/attributes-order
219:3 warning 'formatSize' is assigned a value but never used @typescript-eslint/no-unused-vars
231:7 warning 'groupModes' is assigned a value but never used @typescript-eslint/no-unused-vars
250:12 warning 'e' is defined but never used @typescript-eslint/no-unused-vars
257:12 warning 'e' is defined but never used @typescript-eslint/no-unused-vars
267:12 warning 'e' is defined but never used @typescript-eslint/no-unused-vars
533:7 warning 'DAYS_PER_BATCH' is assigned a value but never used @typescript-eslint/no-unused-vars
534:7 warning 'MAX_DAYS_BACK' is assigned a value but never used @typescript-eslint/no-unused-vars
539:10 warning 'isImageFile' is defined but never used @typescript-eslint/no-unused-vars
920:10 warning 'changeGroupMode' is defined but never used @typescript-eslint/no-unused-vars
988:10 warning 'extractExifDateTime' is defined but never used @typescript-eslint/no-unused-vars
1523:1 warning Async function 'loadMapPhotos' has no 'await' expression require-await
1570:10 warning 'getOldestLoadedDate' is defined but never used @typescript-eslint/no-unused-vars
1726:65 warning '_' is defined but never used @typescript-eslint/no-unused-vars
1726:68 warning 'i' is defined but never used @typescript-eslint/no-unused-vars
1726:71 warning 'arr' is defined but never used @typescript-eslint/no-unused-vars
1838:10 warning 'unobservePhoto' is defined but never used @typescript-eslint/no-unused-vars
2017:10 warning 'openContextMenu' is defined but never used @typescript-eslint/no-unused-vars
2925:12 warning 'e' is defined but never used @typescript-eslint/no-unused-vars
2933:12 warning 'e' is defined but never used @typescript-eslint/no-unused-vars
/drone/src/packages/web-app-photo-addon/tests/unit/usePhotos.spec.ts
7:1 warning Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-explicit-any')
✖ 68 problems (15 errors, 53 warnings)
3 errors and 22 warnings potentially fixable with the --fix option.
ELIFECYCLE Command failed with exit code 1.
Exit Code 1
Typecheck
+ pnpm check:typesweb-extensions@ check:types /drone/src
pnpm -r check:types
Scope: 8 of 9 workspace projects
packages/web-app-cast check:types$ vue-tsc --noEmit
packages/web-app-draw-io check:types$ vue-tsc --noEmit
packages/web-app-importer check:types$ vue-tsc --noEmit
packages/web-app-json-viewer check:types$ vue-tsc --noEmit
packages/web-app-importer check:types: Done
packages/web-app-photo-addon check:types$ vue-tsc --noEmit
packages/web-app-cast check:types: Done
packages/web-app-progress-bars check:types$ vue-tsc --noEmit
packages/web-app-draw-io check:types: Done
packages/web-app-unzip check:types$ vue-tsc --noEmit
packages/web-app-json-viewer check:types: Done
packages/web-app-unzip check:types: Done
packages/web-app-progress-bars check:types: Done
packages/web-app-photo-addon check:types: src/views/PhotosView.vue(141,41): error TS2339: Property '$el' does not exist on type 'Element | ComponentPublicInstance<{}, {}, {}, {}, {}, {}, {}, {}, false, ComponentOptionsBase<any, any, any, any, any, any, any, any, any, {}, {}, string, {}, {}, {}, string, ComponentProvideOptions>, ... 4 more ..., any>'.
packages/web-app-photo-addon check:types: Property '$el' does not exist on type 'Element'.
packages/web-app-photo-addon check:types: src/views/PhotosView.vue(141,62): error TS2339: Property '$el' does not exist on type 'Element | ComponentPublicInstance<{}, {}, {}, {}, {}, {}, {}, {}, false, ComponentOptionsBase<any, any, any, any, any, any, any, any, any, {}, {}, string, {}, {}, {}, string, ComponentProvideOptions>, ... 4 more ..., any>'.
packages/web-app-photo-addon check:types: Property '$el' does not exist on type 'Element'.
packages/web-app-photo-addon check:types: Failed
/drone/src/packages/web-app-photo-addon:
ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL photo-addon@0.1.0 check:types: vue-tsc --noEmit
Exit status 2
ELIFECYCLE Command failed with exit code 2.