Conversation
mmattel
force-pushed
the
update_to_node_v22
branch
from
80950d2 to
9310e91
Compare
LukasHirt
reviewed
Jan 27, 2026
Collaborator
LukasHirt
left a comment
LukasHirt
left a comment
There was a problem hiding this comment.
Any problem with upgrading this already to v24? The image is available in our docker images owncloud-ci/nodejs#143
We're also having the node types dependency already using v24.
mmattel
force-pushed
the
update_to_node_v22
branch
from
9310e91 to
6e95559
Compare
Contributor
Author
|
@LukasHirt done AND CI is green 😄 |
LukasHirt
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates nodejs from v20 to
v22v24.Background:
CI messages in e2e tests, build web apps:
"You are using Node.js 20.17.0. Vite requires Node.js version 20.19+ or 22.12+. Please upgrade your Node.js version."
Updating owncloudci fails because signatures cant be found. Therefore trying to update node itself to the next version.