refactor: clean up codebase to make it at least a little readable #87
Conversation
* feat(locale): use redis to fetch locale when needed get locale from redis or mongo when needed, instead of always setting <User>.locale. Avoids bugs * refactor(util): minor userLocale refactor
|
Here's the code health analysis summary for commits Analysis Summary
|
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -1,7 +1,24 @@ | |||
| import { RegisterInteractionHandler } from '#main/decorators/Interaction.js'; | |||
There was a problem hiding this comment.
File customize.ts has 274 lines of code (exceeds 250 allowed). Consider refactoring.
| ], | ||
| ephemeral: true, | ||
| }); | ||
| await this.replyEmbed( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| ], | ||
| ephemeral: true, | ||
| }); | ||
| await this.replyEmbed( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| ), | ||
| ), | ||
| ], | ||
| await this.replyEmbed( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| ], | ||
| ephemeral: true, | ||
| }); | ||
| await this.replyEmbed( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
dev-737
force-pushed
the
v4
branch
2 times, most recently
from
03b66b2 to
af899ec
Compare
| @@ -1,7 +1,23 @@ | |||
| import { RegisterInteractionHandler } from '#main/decorators/Interaction.js'; | |||
There was a problem hiding this comment.
File customize.ts has 277 lines of code (exceeds 250 allowed). Consider refactoring.
src/events/messageCreate.ts
Outdated
| await storeMessageData(message, sendResult, connection.hubId, dbReferrence); | ||
| } | ||
|
|
||
| private async sendBroadcast( |
There was a problem hiding this comment.
Function sendBroadcast has 72 lines of code (exceeds 25 allowed). Consider refactoring.
| .setURL(`${LINKS.DOCS}/legal/terms`) | ||
| .setEmoji(emojis.docs_icon) | ||
| .setStyle(ButtonStyle.Link), | ||
| new ButtonBuilder() |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| .setURL(`${LINKS.DOCS}/setup`) | ||
| .setEmoji(emojis.guide_icon) | ||
| .setStyle(ButtonStyle.Link), | ||
| new ButtonBuilder() |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| .setFooter({ text: `Sent for: ${guild.name}`, iconURL: guild.iconURL() ?? undefined }); | ||
|
|
||
| const buttons = new ActionRowBuilder<ButtonBuilder>().addComponents( | ||
| new ButtonBuilder() |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| const emojiAlreadyReacted = dbReactions[reactedEmoji] ?? [user.id]; | ||
|
|
||
| // max 10 reactions | ||
| if (Object.keys(dbReactions).length >= 10) return; |
There was a problem hiding this comment.
Avoid too many return statements within this function.
The cache is used/called in the code instead of being used in a middleware on all queries.
|
Code Climate has analyzed commit f37ccb8 and detected 102 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
dev-737
changed the title
WIP