Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 18, 2025

This was introduced in https://github.com/unrs/unrs-resolver/pull/125

The PR description and test case do not explain the reasoning behind this change, and I don't see how it reflects a real-world scenario in modern package managers.

@graphite-app
Copy link

graphite-app bot commented Nov 18, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.89%. Comparing base (8e826e7) to head (ea425f6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
+ Coverage   93.87%   93.89%   +0.02%     
==========================================
  Files          17       17              
  Lines        3084     3079       -5     
==========================================
- Hits         2895     2891       -4     
+ Misses        189      188       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Boshen Boshen force-pushed the 11-18-perf_do_not_canocalize_the_entry_path branch from 15fe8a8 to 688f8f0 Compare November 18, 2025 06:51
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 18, 2025

CodSpeed Performance Report

Merging #848 will improve performances by 8.08%

Comparing 11-18-perf_do_not_canocalize_the_entry_path (ea425f6) with main (8e826e7)1

Summary

⚡ 3 improvements
✅ 8 untouched
⏩ 5 skipped2

Benchmarks breakdown

Benchmark BASE HEAD Change
resolver_memory[resolve from symlinks] 60.5 ms 58.5 ms +3.42%
resolver_real[multi-thread] 508.2 µs 470.3 µs +8.08%
resolver_real[resolve from symlinks] 60.7 ms 58.5 ms +3.78%

Footnotes

  1. No successful run was found on main (ea425f6) during the generation of this report, so 8e826e7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member Author

Boshen commented Nov 18, 2025


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen force-pushed the 11-18-perf_do_not_canocalize_the_entry_path branch 2 times, most recently from 5f9752f to 0c5e98c Compare November 18, 2025 07:30
@Boshen Boshen added the merge label Nov 18, 2025
Copy link
Member Author

Boshen commented Nov 18, 2025

Merge activity

This was introduced in `https://github.com/unrs/unrs-resolver/pull/125`

The PR description and test case do not explain the reasoning behind this change, and I don't see how it reflects a real-world scenario in modern package managers.
@graphite-app graphite-app bot force-pushed the 11-18-perf_do_not_canocalize_the_entry_path branch from 0c5e98c to ea425f6 Compare November 18, 2025 07:39
@graphite-app graphite-app bot merged commit ea425f6 into main Nov 18, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 11-18-perf_do_not_canocalize_the_entry_path branch November 18, 2025 07:43
@Boshen Boshen mentioned this pull request Nov 17, 2025
@graphite-app graphite-app bot removed the merge label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants