-
-
Notifications
You must be signed in to change notification settings - Fork 35
fix: do not resolve to node_modules/pacakge/index
#849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not resolve to node_modules/pacakge/index
#849
Conversation
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
- Coverage 93.89% 93.82% -0.07%
==========================================
Files 17 17
Lines 3079 3079
==========================================
- Hits 2891 2889 -2
- Misses 188 190 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5f9752f to
0c5e98c
Compare
CodSpeed Performance ReportMerging #849 will not alter performanceComparing Summary
Footnotes
|
a9d4093 to
7e33ea2
Compare
0c5e98c to
ea425f6
Compare
7e33ea2 to
9626929
Compare
9626929 to
a27fa13
Compare
Merge activity
|
fixes #845 The option `main_files` is kind of confusing, it's supposed to be the file stem without the extension (e.g. index), but somehow it ended up being a lookup for `index` then `index.js` instead of just `index.js`. This reduces an extra "is file" system call for `node_modules/package/index`.
a27fa13 to
3a9d5e7
Compare

fixes #845
The option
main_filesis kind of confusing, it's supposed to be the file stem without the extension (e.g. index), but somehow it ended up being a lookup forindexthenindex.jsinstead of justindex.js.This reduces an extra "is file" system call for
node_modules/package/index.