Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 18, 2025

fixes #845

The option main_files is kind of confusing, it's supposed to be the file stem without the extension (e.g. index), but somehow it ended up being a lookup for index then index.js instead of just index.js.

This reduces an extra "is file" system call for node_modules/package/index.

Copy link
Member Author

Boshen commented Nov 18, 2025


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.82%. Comparing base (ea425f6) to head (3a9d5e7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   93.89%   93.82%   -0.07%     
==========================================
  Files          17       17              
  Lines        3079     3079              
==========================================
- Hits         2891     2889       -2     
- Misses        188      190       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Boshen Boshen force-pushed the 11-18-perf_do_not_canocalize_the_entry_path branch 2 times, most recently from 5f9752f to 0c5e98c Compare November 18, 2025 07:30
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 18, 2025

CodSpeed Performance Report

Merging #849 will not alter performance

Comparing 11-18-fix_do_not_resolve_to_node_modules_pacakge_index_ (3a9d5e7) with main (ea425f6)1

Summary

✅ 11 untouched
⏩ 5 skipped2

Footnotes

  1. No successful run was found on main (3a9d5e7) during the generation of this report, so ea425f6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen force-pushed the 11-18-fix_do_not_resolve_to_node_modules_pacakge_index_ branch from a9d4093 to 7e33ea2 Compare November 18, 2025 07:33
@Boshen Boshen marked this pull request as draft November 18, 2025 07:39
@graphite-app graphite-app bot changed the base branch from 11-18-perf_do_not_canocalize_the_entry_path to graphite-base/849 November 18, 2025 07:39
@graphite-app graphite-app bot force-pushed the 11-18-fix_do_not_resolve_to_node_modules_pacakge_index_ branch from 7e33ea2 to 9626929 Compare November 18, 2025 07:44
@graphite-app graphite-app bot changed the base branch from graphite-base/849 to main November 18, 2025 07:44
@graphite-app graphite-app bot force-pushed the 11-18-fix_do_not_resolve_to_node_modules_pacakge_index_ branch from 9626929 to a27fa13 Compare November 18, 2025 07:44
@Boshen Boshen marked this pull request as ready for review November 18, 2025 07:51
@Boshen Boshen added the merge label Nov 18, 2025
Copy link
Member Author

Boshen commented Nov 18, 2025

Merge activity

fixes #845

The option `main_files` is kind of confusing, it's supposed to be the file stem without the extension (e.g. index), but somehow it ended up being a lookup for `index` then `index.js` instead of just `index.js`.

This reduces an extra "is file" system call for `node_modules/package/index`.
@graphite-app graphite-app bot force-pushed the 11-18-fix_do_not_resolve_to_node_modules_pacakge_index_ branch from a27fa13 to 3a9d5e7 Compare November 18, 2025 07:51
@graphite-app graphite-app bot merged commit 3a9d5e7 into main Nov 18, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 11-18-fix_do_not_resolve_to_node_modules_pacakge_index_ branch November 18, 2025 07:54
@Boshen Boshen mentioned this pull request Nov 18, 2025
@graphite-app graphite-app bot removed the merge label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: incorrect resolution of node_modules/package/index

2 participants