Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Dec 4, 2025

This is the 3rd case in https://github.com/microsoft/TypeScript/issues/62207

This PR forbids resolution of foo.js if tsconfig.conf does not have a baseUrl and allows resolution of foo.js if tsconfig.conf has a baseUrl

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.29%. Comparing base (79b5660) to head (a58399d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
+ Coverage   94.25%   94.29%   +0.04%     
==========================================
  Files          17       17              
  Lines        3307     3315       +8     
==========================================
+ Hits         3117     3126       +9     
+ Misses        190      189       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2025

CodSpeed Performance Report

Merging #903 will not alter performance

Comparing fix-base-url (a58399d) with main (79b5660)

Summary

✅ 12 untouched
⏩ 5 skipped1

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen merged commit 0ba0db9 into main Dec 4, 2025
18 checks passed
@Boshen Boshen deleted the fix-base-url branch December 4, 2025 11:04
@Boshen Boshen mentioned this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants