Skip to content

fix: encode sourcesContent null as raw null instead of quoted string#291

Merged
Boshen merged 1 commit intomainfrom
fix/sourcecontent-null-encoding
Mar 20, 2026
Merged

fix: encode sourcesContent null as raw null instead of quoted string#291
Boshen merged 1 commit intomainfrom
fix/sourcecontent-null-encoding

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Mar 20, 2026

Summary

  • None entries in source_contents were passed as the string "null" through escape_into, producing "null" (a JSON string) instead of the raw JSON null token.
  • Write null bytes directly for None entries, only running escape_into for Some values.

🤖 Generated with Claude Code

`None` entries in `source_contents` were passed as the string `"null"`
through `escape_into`, which produced `"null"` (a JSON string) instead
of the raw JSON `null` token.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2026

Merging this PR will not alter performance

✅ 13 untouched benchmarks
⏩ 5 skipped benchmarks1


Comparing fix/sourcecontent-null-encoding (bb6c05a) with main (b45a772)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen merged commit ac607a0 into main Mar 20, 2026
7 checks passed
@Boshen Boshen deleted the fix/sourcecontent-null-encoding branch March 20, 2026 13:38
@Boshen Boshen mentioned this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant