perf(napi/transform): do not create temp String#10752
Merged
graphite-app[bot] merged 1 commit intomainfrom May 1, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 1, 2025
github-actions
bot
added
the
C-performance
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
05-01-perf_transformer_inject_global_variables_do_not_search_string_twice
branch
from
4709038 to
699ab3e
Compare
graphite-app
bot
force-pushed
the
05-01-perf_napi_transform_do_not_create_temp_string_
branch
from
00cb125 to
88249f7
Compare
Base automatically changed from
05-01-perf_transformer_inject_global_variables_do_not_search_string_twice
to
main
May 1, 2025 13:44
graphite-app
bot
deleted the
05-01-perf_napi_transform_do_not_create_temp_string_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid an allocation.
to_stringhere clones aStringand then immediately converts it back to a&str. Avoid that intermediate allocation.