chore(infra): use oxfmt for all files, remove dprint #16599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the project's formatting infrastructure from dprint to oxfmt, completing the transition to using oxfmt for all supported file types (JavaScript, TypeScript, JSON, YAML, Markdown, CSS, HTML, etc.). TOML formatting is acknowledged as missing but deferred until oxfmt plugin support is available.
Key Changes:
- Removed dprint as a project dependency and deleted its configuration
- Updated oxfmtrc.jsonc with additional ignore patterns for CHANGELOG.md, snapshot files, and pnpm-lock.yaml
- Updated all GitHub workflows to remove dprint installation and caching steps
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| oxfmtrc.jsonc | Added ignore patterns for CHANGELOG.md, *.snap.md files, and pnpm-lock.yaml |
| justfile | Removed dprint from init command and fmt recipe; updated documentation comments |
| dprint.json | Deleted entire dprint configuration file |
| AGENTS.md | Removed dprint from the list of pre-installed tools |
| .github/workflows/update_submodules.yml | Removed dprint from tools list |
| .github/workflows/dprint.yml | Deleted entire workflow for dprint plugin caching |
| .github/workflows/copilot-setup-steps.yml | Removed dprint tool installation and cache restoration steps |
| .github/workflows/autofix.yml | Removed dprint tool installation and cache restoration steps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Boshen
force-pushed
the
12-08-chore_infra_use_oxfmt_for_all_files_remove_dprint
branch
from
0723a18 to
42ffa36
Compare
github-actions
bot
added
A-linter
Boshen
force-pushed
the
12-08-chore_infra_use_oxfmt_for_all_files_remove_dprint
branch
7 times, most recently
from
720ec81 to
542cfd6
Compare
Member
Author
Merge activity
|
Boshen
force-pushed
the
12-08-chore_infra_use_oxfmt_for_all_files_remove_dprint
branch
from
542cfd6 to
aa42950
Compare
Toml formatting is missing but there's only a few toml files, can wait for oxfmt plugins. - [x] Something is slow, can't figure out why, need #16607
graphite-app
bot
force-pushed
the
12-08-chore_infra_use_oxfmt_for_all_files_remove_dprint
branch
from
aa42950 to
6fca2f7
Compare
graphite-app
bot
deleted the
12-08-chore_infra_use_oxfmt_for_all_files_remove_dprint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toml formatting is missing but there's only a few toml files, can wait
for oxfmt plugins.