Conversation
This prevents the DefaultHandlerExceptionResolver from sending it's log lines to sentry, they are still logged in the application logs (in case we hit problems and they provide something useful).
There was a problem hiding this comment.
Pull request overview
Adds a Spring Boot configuration to prevent certain Spring MVC handled-exception logs from being sent to Sentry, reducing noise while keeping the messages in the application logs.
Changes:
- Introduce a
@Configurationthat registers aSentryOptions.BeforeSendCallbackbean. - Drop Sentry events whose
event.getLogger()matchesorg.springframework.web.servlet.mvc.support.DefaultHandlerExceptionResolver.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/uk/ac/ox/ctl/SentryLoggingFilterConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/ac/ox/ctl/SentryLoggingFilterConfiguration.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Co-authored-by: buckett <5921+buckett@users.noreply.github.com>
Apply review feedback: use class reference and add unit tests
sebastianchristopher
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BeforeSendCallbackwith Sentryorg.springframework.web.servlet.mvc.support.DefaultHandlerExceptionResolverso they stay in the app log but never hit SentryTesting